Skip to content

Conversation

brb
Copy link
Contributor

@brb brb commented Jun 17, 2019

This PR extends the LinkAdd() function for Veth by allowing to specify peer hardware address.

@brb brb force-pushed the veth-peer-mac-addr branch from 8d3b7a0 to 4b9f84c Compare June 17, 2019 18:56
This commit extends LinkAdd function for Veth by allowing to specify
peer hardware addr.

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@aboch
Copy link
Collaborator

aboch commented Jun 17, 2019

LGTM

brb added a commit to cilium/cilium that referenced this pull request Jun 18, 2019
This commit temporarily updated the vishvananda/netlink dependency
to point to brb/netlink@veth-peer-mac-addr to support setting
MAC addr for a peer when creating veth iface.

This commit can be reverted after vishvananda/netlink#460
has been merged.

Signed-off-by: Martynas Pumputis <m@lambda.lt>
Copy link
Contributor

@jellonek jellonek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aboch aboch merged commit 99a56c2 into vishvananda:master Jun 18, 2019
brb added a commit to cilium/cilium that referenced this pull request Jun 19, 2019
To include the change which allows to specify veth peer mac address
(vishvananda/netlink#460).

Signed-off-by: Martynas Pumputis <m@lambda.lt>
brb added a commit to cilium/cilium that referenced this pull request Jun 20, 2019
To include the change which allows to specify veth peer mac address
(vishvananda/netlink#460).

Signed-off-by: Martynas Pumputis <m@lambda.lt>
tgraf pushed a commit to cilium/cilium that referenced this pull request Jun 20, 2019
To include the change which allows to specify veth peer mac address
(vishvananda/netlink#460).

Signed-off-by: Martynas Pumputis <m@lambda.lt>
aanm pushed a commit to cilium/cilium that referenced this pull request Jun 25, 2019
[ upstream commit a8bb290 ]

To include the change which allows to specify veth peer mac address
(vishvananda/netlink#460).

Signed-off-by: Martynas Pumputis <m@lambda.lt>
Signed-off-by: André Martins <andre@cilium.io>
tgraf pushed a commit to cilium/cilium that referenced this pull request Jun 27, 2019
[ upstream commit a8bb290 ]

To include the change which allows to specify veth peer mac address
(vishvananda/netlink#460).

Signed-off-by: Martynas Pumputis <m@lambda.lt>
Signed-off-by: André Martins <andre@cilium.io>
jrajahalme pushed a commit to cilium/cilium that referenced this pull request Jun 27, 2019
[ upstream commit a8bb290 ]

To include the change which allows to specify veth peer mac address
(vishvananda/netlink#460).

Signed-off-by: Martynas Pumputis <m@lambda.lt>
Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
joestringer pushed a commit to cilium/cilium that referenced this pull request Jun 29, 2019
[ upstream commit a8bb290 ]

To include the change which allows to specify veth peer mac address
(vishvananda/netlink#460).

Signed-off-by: Martynas Pumputis <m@lambda.lt>
Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
ianvernon pushed a commit to cilium/cilium that referenced this pull request Jul 10, 2019
[ upstream commit a8bb290 ]

To include the change which allows to specify veth peer mac address
(vishvananda/netlink#460).

Signed-off-by: Martynas Pumputis <m@lambda.lt>
SIgned-off by: Ian Vernon <ian@cilium.io>
ianvernon pushed a commit to cilium/cilium that referenced this pull request Jul 11, 2019
[ upstream commit a8bb290 ]

To include the change which allows to specify veth peer mac address
(vishvananda/netlink#460).

Signed-off-by: Martynas Pumputis <m@lambda.lt>
SIgned-off by: Ian Vernon <ian@cilium.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants