-
Notifications
You must be signed in to change notification settings - Fork 792
veth: Set peer hardware addr when creating #460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit extends LinkAdd function for Veth by allowing to specify peer hardware addr. Signed-off-by: Martynas Pumputis <m@lambda.lt>
2 tasks
LGTM |
brb
added a commit
to cilium/cilium
that referenced
this pull request
Jun 18, 2019
This commit temporarily updated the vishvananda/netlink dependency to point to brb/netlink@veth-peer-mac-addr to support setting MAC addr for a peer when creating veth iface. This commit can be reverted after vishvananda/netlink#460 has been merged. Signed-off-by: Martynas Pumputis <m@lambda.lt>
jellonek
approved these changes
Jun 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
brb
added a commit
to cilium/cilium
that referenced
this pull request
Jun 19, 2019
To include the change which allows to specify veth peer mac address (vishvananda/netlink#460). Signed-off-by: Martynas Pumputis <m@lambda.lt>
brb
added a commit
to cilium/cilium
that referenced
this pull request
Jun 20, 2019
To include the change which allows to specify veth peer mac address (vishvananda/netlink#460). Signed-off-by: Martynas Pumputis <m@lambda.lt>
tgraf
pushed a commit
to cilium/cilium
that referenced
this pull request
Jun 20, 2019
To include the change which allows to specify veth peer mac address (vishvananda/netlink#460). Signed-off-by: Martynas Pumputis <m@lambda.lt>
aanm
pushed a commit
to cilium/cilium
that referenced
this pull request
Jun 25, 2019
[ upstream commit a8bb290 ] To include the change which allows to specify veth peer mac address (vishvananda/netlink#460). Signed-off-by: Martynas Pumputis <m@lambda.lt> Signed-off-by: André Martins <andre@cilium.io>
tgraf
pushed a commit
to cilium/cilium
that referenced
this pull request
Jun 27, 2019
[ upstream commit a8bb290 ] To include the change which allows to specify veth peer mac address (vishvananda/netlink#460). Signed-off-by: Martynas Pumputis <m@lambda.lt> Signed-off-by: André Martins <andre@cilium.io>
jrajahalme
pushed a commit
to cilium/cilium
that referenced
this pull request
Jun 27, 2019
[ upstream commit a8bb290 ] To include the change which allows to specify veth peer mac address (vishvananda/netlink#460). Signed-off-by: Martynas Pumputis <m@lambda.lt> Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
joestringer
pushed a commit
to cilium/cilium
that referenced
this pull request
Jun 29, 2019
[ upstream commit a8bb290 ] To include the change which allows to specify veth peer mac address (vishvananda/netlink#460). Signed-off-by: Martynas Pumputis <m@lambda.lt> Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
ianvernon
pushed a commit
to cilium/cilium
that referenced
this pull request
Jul 10, 2019
[ upstream commit a8bb290 ] To include the change which allows to specify veth peer mac address (vishvananda/netlink#460). Signed-off-by: Martynas Pumputis <m@lambda.lt> SIgned-off by: Ian Vernon <ian@cilium.io>
ianvernon
pushed a commit
to cilium/cilium
that referenced
this pull request
Jul 11, 2019
[ upstream commit a8bb290 ] To include the change which allows to specify veth peer mac address (vishvananda/netlink#460). Signed-off-by: Martynas Pumputis <m@lambda.lt> SIgned-off by: Ian Vernon <ian@cilium.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the
LinkAdd()
function forVeth
by allowing to specify peer hardware address.