Skip to content

ipset revision usage is inconsistent with ipset binary from netfilter #1030

@bleggett

Description

@bleggett

Example:

For hash:ip,port, this library defaults to revision=1: https://github.com/vishvananda/netlink/blob/main/ipset_linux.go#L398.

But the ipset binary code comments indicate we should be using at least revision=3 here (since this library supports using comments with that set type) https://github.com/Olipro/ipset/blob/9f145b49100104d6570fe5c31a5236816ebb4f8f/kernel/net/netfilter/ipset/ip_set_hash_ipport.c#L30

For hash:ip, this library defaults to revision=0. But the ipset binary code comments indicate we should be using at least revision=2 here (since this library supports using comments with this set type as well): https://github.com/Olipro/ipset/blob/9f145b49100104d6570fe5c31a5236816ebb4f8f/kernel/net/netfilter/ipset/ip_set_hash_ip.c#L28

In general, we should probably track the set-level revisions that the ipset binary does.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions