-
Notifications
You must be signed in to change notification settings - Fork 24
Fixed edge cases for bash completion #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hmm, would you please describe more details? |
completion like: |
Yes, it seems good :)
It's slightly different. I found the case that completion does not work:
doesn't complete |
yes, I fixed it, you just have to swap the first and second if statement in the large block and renama if/elif.
I am not used to working with github yet, so I don't know how to work with forked repos and other things soefficiently |
Okay, confirmed that the patch fixes
You can commit the change, and |
Thank you, it worked. I also removed the |new| part of the first if, because "new" does not receive an existing profile as argument. |
Perfect! Merged it :) |
Various edge cases have been solved, such as completion for invalid subcommands etc.