Skip to content

"volt edit {repository}" drops {repository} #280

@mrymtsk

Description

@mrymtsk

Newly implemented subcommand "volt edit {repository}" (#278) seems to drop the {repository}.

$ volt get tyru/caw.vim
[INFO] Full building /Users/Toshiki/.vim/pack/volt/opt directory ...
[INFO] Installing vimrc and gvimrc ...
+ github.com/tyru/caw.vim > installed

$ cat ~/volt/lock.json
{
  "version": 2,
  "current_profile_name": "default",
  "repos": [
    {
      "type": "git",
      "path": "github.com/tyru/caw.vim",
      "version": "98805a60aef339e55e5b917fdb9f69c74e8d8340"
    }
  ],
  "profiles": [
    {
      "name": "default",
      "repos_path": [
        "github.com/tyru/caw.vim"
      ]
    }
  ]
}
$ volt edit tyru/caw.vim
# any edit

$ cat ~/volt/lock.json
{
  "version": 2,
  "current_profile_name": "default",
  "repos": [],
  "profiles": [
    {
      "name": "default",
      "repos_path": []
    }
  ]
}

volt/subcmd/edit.go

Lines 137 to 142 in b1c9efd

// Remove repository from lock.json
err = lockJSON.Repos.RemoveAllReposPath(reposPath)
err2 := lockJSON.Profiles.RemoveAllReposPath(reposPath)
if err == nil || err2 == nil {
// ignore?
}

Probably this block is related to this issue? If I remove this block and compile volt it works as expected.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions