Disable part loading for subtitle playlists #7463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-stream-controller, timeline-contoller, fragment-tracker...) Stop gap measure for #7460
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Disable part loading for subtitle playlists
Why is this Pull Request needed?
Part loading has not been fully implemented in the subtitle-stream-controller, timeline-contoller, fragment-tracker, and other components that deal with tracking part loaded state needed for fragment selection and part loading progression.
Are there any points in the code the reviewer needs to double check?
Resolves issues:
This is a stop gap measure for #7460. Rather than allow attempts at part loading which are not handled in sequence successfully (at best the first part is loaded and others skipped), the subtitle-stream-controller will only load complete segments,
Checklist