Detect unhandled encryption and fallback or error #7454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't error if mediaKeys are set in case of custom EME integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Detect unhandled encryption (cbcs) in mp4 init segments and fallback or error when hls.js is not configured to use EME.
No error or fallback is performed if media is detached or media.mediaKeys is set. This is to allow for custom EME integrations.
When hls.js is setup with
emeEnabled: truethis check is skipped because the "encrypted" event handler will error if there is no configured key-system and associated license information.Why is this Pull Request needed?
This handles improperly packaged HLS carrying encrypted segments without any KEY tags to signal the encryption.
This does not apply to full segment encryption.
Are there any points in the code the reviewer needs to double check?
Resolves issues:
Checklist