Fix subtitle segment loading at live start #7349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
I think it works. :-) |
06c3465 to
0912131
Compare
…scontinuity Fixes #7347
0912131 to
e19438a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Fix subtitle segment loading hanging on live start with mismatched discontinuity
Why is this Pull Request needed?
The subtitle-stream-controller must determine where to begin loading segments in the same way that the audio-stream-controller does, in sync with the live start determined by the main stream-controller.
Are there any points in the code the reviewer needs to double check?
If subtitle segments are loaded in another discontinuity domain for which the init PTS is not resolved, the segment data should be dropped, and subtitle segment loading resumed.
Resolves issues:
Fixes #7347
Checklist