Fix delta playlist update discontinuity regression #7292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Fix delta playlist update discontinuity regression introduced in v1.6.2 with #7168
Why is this Pull Request needed?
In making sure that discontinuity sequences were synchronized between playlist updates without #EXT-X-DISCONTINUITY-SEQUENCE (#7168), a regression was introduced in handling of delta playlists where segments that were skipped are expected to provide a discontinuity sequence (
newFragments[0].cc).Are there any points in the code the reviewer needs to double check?
These changes make sure that the discontinuity sequence
ccis being updated for segments in both cases (#EXT-X-DISCONTINUITY-SEQUENCE and Delta Playlist updates), and thatstartCCandendCCare set towards the end of merging details after skipped segments have been patched.Resolves issues:
Fixes #7282
Checklist