Skip to content

docs: add note regarding ESM use with old browsers #7203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

nebutch
Copy link
Contributor

@nebutch nebutch commented Apr 28, 2025

This PR will...

Adds a note to the MIGRATING document regarding performance issues on older web engines (for example, Chrome v56/63 on Samsung TV's).

Why is this Pull Request needed?

Performance issues discovered when using the ESM (default) version of this library when compiling client applications in strict mode. Communicates recommendations to avoid this.

Are there any points in the code the reviewer needs to double check?

n/a

Addresses issues:

#7106

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch added this to the 1.6.3 milestone Apr 28, 2025
@robwalch robwalch merged commit c4d25a2 into video-dev:master Apr 28, 2025
12 checks passed
@nebutch nebutch deleted the chore/es5_migration_note_rebased branch April 29, 2025 10:05
@robwalch robwalch moved this from Top priorities to Nice to have in HLS.js Release Planning and Backlog May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants