Setup eslint no for loops rule #7202
Conversation
|
Thanks @robwalch for quickly looking and merging the PR. Will look forward to making more contributions here😊 |
|
Thank you @satyam73, You can see some of the planned work in the release and backlog project (HLS.js Release Planning and Backlog (view)) or in the milestones. There is a lot unplanned work in issues. For contributions, I'm most interested in what problems you face using hls.js and what solutions would benefit you and other users. If instead you are looking for more dependency related issues that touch more of the workflow, there is (it could be very simple or very difficult as the mock XHR interface in sinon can be tricky and we don't want to loose any coverage): |
Sure will look into these and let you know, thanks for guiding and helping |
This PR will add the eslint rule to disallow using the for of loops across the codebase
Why is this Pull Request needed?
This pull request is being created with reference to this conversation as below where we discussed that it will be better that we setup this eslint rule so that it automatically gives error for using for of loops, maintaining code consistency.
Are there any points in the code the reviewer needs to double check?
I have updated at once place where for of loop was being used and I have replace it with
forEachso we can check that part once.Resolves issues:
Checklist