Skip to content

chore(deps): update dependency sinon to v20 #7141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

chore(deps): update dependency sinon to v20 #7141

wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 31, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
sinon (source) 19.0.5 -> 20.0.0 age adoption passing confidence

Release Notes

sinonjs/sinon (sinon)

v20.0.0

Compare Source

  • b6daed26
    chore!: remove usingPromise (Morgan Roderick)

    Everyone should be using native promises by now, or should know how to stub natives

  • 95d4b8fc
    chore!: remove fakeXMLHttpRequest and fakeServer (Morgan Roderick)

    BREAKING CHANGE: remove fakeXMLHttpRequest and fakeServer from the API

Released by Morgan Roderick on 2025-03-24.

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added dependencies Pull requests that update a dependency file semver-major skip-change-log Do not include the PR in the change log in the release labels Mar 31, 2025
@renovate renovate bot force-pushed the renovate/sinon-20.x branch 11 times, most recently from 7402055 to ca2a49b Compare April 3, 2025 19:13
@renovate renovate bot force-pushed the renovate/sinon-20.x branch from ca2a49b to c6b30df Compare April 3, 2025 20:39
@robwalch
Copy link
Collaborator

robwalch commented Apr 4, 2025

It appears that useFakeXMLHttpRequest is no longer available in sinon v20 causing unit tests to fail https://github.com/video-dev/hls.js/actions/runs/14252348454/job/39947972059

Changes are required to migrate: https://sinonjs.org/releases/v2/migrating-to-2.0/

In Sinon 1.x, the sandbox’ useFakeXMLHttpRequest was the same as its useFakeServer. In 2.x, it maps directly to sinon.useFakeXMLHttpRequest (but with sandboxing). If you use sandbox.useFakeXMLHttpRequest, just replace it with sandbox.useFakeServer, and your tests should behave as they always did.

@robwalch robwalch closed this Apr 4, 2025
@renovate Renovate
Copy link
Contributor Author

renovate bot commented Apr 4, 2025

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 20.x releases. But if you manually upgrade to 20.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate renovate bot deleted the renovate/sinon-20.x branch April 4, 2025 19:12
@robwalch robwalch mentioned this pull request Apr 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file semver-major skip-change-log Do not include the PR in the change log in the release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@robwalch