Skip to content

fix: missing throwOnError in SWRMutationHook options #3054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 24, 2024
Merged

fix: missing throwOnError in SWRMutationHook options #3054

merged 3 commits into from
Dec 24, 2024

Conversation

Ram4GB
Copy link
Contributor

@Ram4GB Ram4GB commented Dec 17, 2024

Missing throwOnError in SWRMutationHook's options. Update code to let users pass option throwOnError.

Example:

useSWRMutation('/api/mutate-server-action', () => action(), { throwOnError: true })

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Dec 17, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@huozhi
Copy link
Member

huozhi commented Dec 23, 2024

Types check is still failing, we can land it once it's pssed!

@Ram4GB Ram4GB requested a review from huozhi December 23, 2024 15:27
@huozhi huozhi merged commit 2684b72 into vercel:main Dec 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ram4GB @huozhi