build: simplify react-server export and update bundler #2897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/bunchee@4.3.4 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
shuding
requested changes
Feb 18, 2024
There was a problem hiding this comment.
This approach now bundles the code for SWRConfig, whereas the current main branch re-exports SWRConfig from swr/_internal. So this change kinda "clones" the module instead of sharing the same instance.
We need to ensure that 1️⃣ and 2️⃣ are the same instance:
-
server layer, import SWRConfig
- enters "use client"
- exports SWRConfig // ← 1️⃣
- enters "use client"
-
client layer, import SWRConfig
- exports SWRConfig // ← 2️⃣
eb6a748 to
f5a65cd
Compare
shuding
approved these changes
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.