This repository was archived by the owner on Jan 3, 2024. It is now read-only.
utils: switch to "node-fetch" and add proxy support #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertsLando
suggested changes
May 11, 2021
lib/utils.ts
Outdated
| throw wasReported(e.message); | ||
| } | ||
| }); | ||
| return promisify(stream.finished)(ws).then(() => { |
There was a problem hiding this comment.
I would prefer to await this, also promisify in that way could loose the context, I usually use .bind or .call when using it:
promisify(stream.finished).call(stream, ws)
There was a problem hiding this comment.
Also could this throw? I see you removed error handling
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: #177, vercel/pkg#1163