CI: add binary workflows #153
Conversation
|
Why don't just create a draft release now and instead of uploading artifacts directly upload tags to that release? |
|
I'm all in favor of whatever reduces the amount of manual work needed. Less chance for me to make mistakes 😄 |
|
It is indeed possible to add workflows that create and upload binaries to a release automatically. However, that may not be desired in some cases. For instance, we may want to coordinate release with npm side, and we may not want to override existing release assets before we actually do a release. This change definitely makes things significantly easier. Maintainers no longer have to spend (tens of) hours with different build configurations and machines. Though, we still have some relatively trivial jobs to do: fetch binaries from Actions, rename, and upload to Releases. |
|
I would (at least) remove the need to rename them, I'm still not 100% sure about the manual downlaod/upload as it takes some (useless) time to download ad upload them... I think that once we have them on assets we could decide if drop or keep them. Maybe we could add a check and if the asset is already present on relase don't override it but upload as artifact or with a (2) at the end so we can later decide which one to keep. Manual rename could have some typos and I think we should make this part almost all automated |
|
Reply to all Node 8 comments: Because Node 8 is still in the Per our previous discussions, we may want to allow at least one recently deprecated Node version. |
|
@leerob Let's go on with this as it is a must have |
Linux: https://github.com/jesec/pkg-fetch/actions/runs/711723135
Windows: https://github.com/jesec/pkg-fetch/actions/runs/711723405
macOS: https://github.com/jesec/pkg-fetch/actions/runs/711723492
This should allow us to release 3.0.
@leerob , after we merge this change, please:
Actionsand run binary workflows.Actionsafter workflows finish.built-*tonode-*.v3.0release. (strictly vMAJOR.MINOR here. no patch. patch releases are not expected to change binaries)Users of
pkgare not going to be affected by the newpkg-fetchrelease at this moment, aspkguses a pre-defined version ofpkg-fetch.With a new release of
pkg-fetchand binaries ready, we can go back topkg, bump thepkg-fetch, and run the test suite. If everything goes well, we can do a release there, but we can also wait a while.I plan to add support for a fully static (Linux) variant soon. Additionally, I think we can tweak the
configurearguments of Node to make the binaries smaller. And, should westrip(debugging symbols from) binaries?