Skip to content

docs: Add Tolgee to app router localization resources #81366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 1, 2025
Merged

docs: Add Tolgee to app router localization resources #81366

merged 3 commits into from
Aug 1, 2025

Conversation

stepan662
Copy link
Contributor

Adding Tolgee to available i18n providers.

Why

Tolgee is listed only in the pages-router, but it actually supports app-router as well.

@ijjk ijjk added the Documentation Related to Next.js' official documentation. label Jul 7, 2025
@ijjk
Copy link
Member

ijjk commented Jul 7, 2025 •
edited by bgw
Loading

Allow CI Workflow Run

  • approve CI run for commit: 9a65e38

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

bgw
bgw approved these changes Jul 9, 2025
View reviewed changes
Copy link
Member

@bgw bgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a self-promotion, but I'm approving specifically because this is already in the pages router doc (I double-checked).

This should merge once we get a clean CI run.

@bgw bgw enabled auto-merge (squash) July 9, 2025 02:05
@ijjk
Copy link
Member

ijjk commented Jul 9, 2025

Failing test suites

Commit: 41cb21a

pnpm test-start test/e2e/app-dir/underscore-ignore-app-paths/underscore-ignore-app-paths.test.ts

  • underscore-ignore-app-paths > should not serve app path with underscore
  • underscore-ignore-app-paths > should serve pages path with underscore
  • underscore-ignore-app-paths > should serve app path with %5F
Expand output

● underscore-ignore-app-paths › should not serve app path with underscore

next build failed with code/signal 1

  106 |           if (code || signal)
  107 |             reject(
> 108 |               new Error(`next build failed with code/signal ${code || signal}`)
      |               ^
  109 |             )
  110 |           else resolve()
  111 |         })

  at ChildProcess.<anonymous> (lib/next-modes/next-start.ts:108:15)

● underscore-ignore-app-paths › should serve pages path with underscore

next build failed with code/signal 1

  106 |           if (code || signal)
  107 |             reject(
> 108 |               new Error(`next build failed with code/signal ${code || signal}`)
      |               ^
  109 |             )
  110 |           else resolve()
  111 |         })

  at ChildProcess.<anonymous> (lib/next-modes/next-start.ts:108:15)

● underscore-ignore-app-paths › should serve app path with %5F

next build failed with code/signal 1

  106 |           if (code || signal)
  107 |             reject(
> 108 |               new Error(`next build failed with code/signal ${code || signal}`)
      |               ^
  109 |             )
  110 |           else resolve()
  111 |         })

  at ChildProcess.<anonymous> (lib/next-modes/next-start.ts:108:15)

Read more about building and testing Next.js in contributing.md.

@stepan662
Copy link
Contributor Author

Thank you @ijjk. Not sure why the CI is not passing, seems like it's missing some labels.

@stepan662
Copy link
Contributor Author

Hi, @bgw could we merge this? We would be really happy as now it can look like we only support pages router and not the app router.

@bgw
Copy link
Member

bgw commented Aug 1, 2025

Sorry about that, I enabled auto-merge but didn't follow up on the CI. I'm re-running the jobs now.

@bgw bgw merged commit 49ac27c into vercel:canary Aug 1, 2025
192 of 199 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgw bgw bgw approved these changes

Assignees
No one assigned
Labels
Documentation Related to Next.js' official documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stepan662 @ijjk @bgw