docs: polyfills usage in app router #80447
Merged
+230
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delbaoliveira
approved these changes
Jun 13, 2025
ztanner
reviewed
Jun 23, 2025
There was a problem hiding this comment.
we're adding quite a bit of detail to how to handle polyfills in app router but the pages router approach is fairly handwavy.
Presumably some of the strategies we're talking about in app router would apply to pages router (eg loading the module in the individual component) so perhaps we can split this out into things that are truly router specific? (Which I think would just be importing it into a root layout rather than the _app component)
docs/01-app/03-api-reference/03-file-conventions/instrumentation-client.mdx
Outdated
Show resolved
Hide resolved
ztanner
reviewed
Aug 5, 2025
docs/01-app/03-api-reference/03-file-conventions/instrumentation-client.mdx
Outdated
Show resolved
Hide resolved
ztanner
reviewed
Aug 6, 2025
Comment on lines
56
to
62
| ```ts filename="instrumentation-client.ts" switcher | ||
| import './polyfills' | ||
| ``` | ||
|
|
||
| ```js filename="instrumentation-client.js" switcher | ||
| import './polyfills' | ||
| ``` |
There was a problem hiding this comment.
do we need switcher when the code is the same?
|
|
||
| To include polyfills, you can import them into the [`instrumentation-client.js` file](/docs/app/api-reference/file-conventions/instrumentation-client). | ||
|
|
||
| For other cases, you can create a client module that loads the polyfills you need. For example if you only want to polyfill client side: |
There was a problem hiding this comment.
This paragraph doesn't seem right here since it comes right before the instrumentation-client code snippet
ztanner
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: https://linear.app/vercel/issue/DOC-4752/docs-polyfills-in-app-router
Fixes: #74730