Skip to content

Move webpack aliases into separate file #57233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 23, 2023
Merged

Move webpack aliases into separate file #57233

merged 2 commits into from
Oct 23, 2023

Conversation

timneutkens
Copy link
Member

Refactoring the webpack-config.ts file to no longer have all aliases defined, instead they are in a separate file which should make refactoring these to use them in Turbopack simpler.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Oct 23, 2023
@timneutkens
Copy link
Member Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@ijjk
Copy link
Member

ijjk commented Oct 23, 2023 •
edited
Loading

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary vercel/next.js 10-22-Move_webpack_aliases_into_separate_file Change
buildDuration 10.8s 10.7s N/A
buildDurationCached 6.2s 6.2s N/A
nodeModulesSize 174 MB 174 MB ⚠️ +13.2 kB
nextStartRea..uration (ms) 527ms 522ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 10-22-Move_webpack_aliases_into_separate_file Change
199-HASH.js gzip 27.6 kB 27.7 kB N/A
3f784ff6-HASH.js gzip 53.3 kB 53.3 kB ✓
99.HASH.js gzip 182 B 182 B ✓
framework-HASH.js gzip 45.3 kB 45.3 kB ✓
main-app-HASH.js gzip 253 B 252 B N/A
main-HASH.js gzip 32.9 kB 32.9 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 98.8 kB 98.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 10-22-Move_webpack_aliases_into_separate_file Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js 10-22-Move_webpack_aliases_into_separate_file Change
_app-HASH.js gzip 206 B 205 B N/A
_error-HASH.js gzip 182 B 180 B N/A
amp-HASH.js gzip 506 B 505 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.57 kB 2.57 kB N/A
edge-ssr-HASH.js gzip 260 B 259 B N/A
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 369 B 369 B ✓
image-HASH.js gzip 4.36 kB 4.36 kB N/A
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.64 kB 2.63 kB N/A
routerDirect..HASH.js gzip 312 B 311 B N/A
script-HASH.js gzip 385 B 384 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 1.08 kB 1.08 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js 10-22-Move_webpack_aliases_into_separate_file Change
_buildManifest.js gzip 484 B 482 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js 10-22-Move_webpack_aliases_into_separate_file Change
index.html gzip 530 B 529 B N/A
link.html gzip 542 B 542 B ✓
withRouter.html gzip 524 B 524 B ✓
Overall change 1.07 kB 1.07 kB ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 10-22-Move_webpack_aliases_into_separate_file Change
edge-ssr.js gzip 93.8 kB 93.8 kB N/A
page.js gzip 155 kB 155 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js 10-22-Move_webpack_aliases_into_separate_file Change
middleware-b..fest.js gzip 626 B 623 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 22.9 kB 22.9 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB ✓
Overall change 1.92 kB 1.92 kB ✓
Commit: e95e9d0

@ijjk
Copy link
Member

ijjk commented Oct 23, 2023

Failing test suites

Commit: e95e9d0

pnpm test test/integration/build-indicator/test/index.test.js

  • Build Activity Indicator > Enabled > Shows the build indicator when a page is built during navigation
Expand output

● Build Activity Indicator › Enabled › Shows the build indicator when a page is built during navigation

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  81 |       await waitFor(500)
  82 |       const wasVisible = await browser.eval('window.showedBuilder')
> 83 |       expect(wasVisible).toBe(true)
     |                          ^
  84 |       await browser.close()
  85 |     })
  86 |

  at Object.toBe (integration/build-indicator/test/index.test.js:83:26)

Read more about building and testing Next.js in contributing.md.

@kodiakhq kodiakhq bot merged commit 87c8e01 into canary Oct 23, 2023
@kodiakhq kodiakhq bot deleted the 10-22-Move_webpack_aliases_into_separate_file branch October 23, 2023 01:26
@github-actions github-actions bot added the locked label Nov 6, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sokra sokra sokra approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

@ztanner ztanner Awaiting requested review from ztanner

@feedthejim feedthejim Awaiting requested review from feedthejim

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. locked type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timneutkens @ijjk @sokra