Skip to content

Mark most GTMParams as optional #57153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 20, 2023
Merged

Mark most GTMParams as optional #57153

merged 2 commits into from
Oct 20, 2023

Conversation

philwolstenholme
Copy link
Contributor

Fixes #57126

The <GoogleTagManager> types in @next/third-parties seem incorrect compared to e2e test usage where only the gtmId is shown/needed.

<GoogleTagManager gtmId="GTM-XYZ" />

The extra options (datalayer name etc) are not needed as the GoogleTagManager has defaults: https://github.com/vercel/next.js/blob/v13.5.7-canary.11/packages/third-parties/src/google/gtm.tsx#L24-L32

@philwolstenholme philwolstenholme mentioned this pull request Oct 20, 2023
Closed
1 task
@ijjk
Copy link
Member

ijjk commented Oct 20, 2023 •
edited by balazsorban44
Loading

Allow CI Workflow Run

  • approve CI run for commit: 935c494

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Member

ijjk commented Oct 20, 2023

Stats from current PR

Default Build
General
vercel/next.js canary philwolstenholme/next.js 57126 Change
buildDuration 10.3s 10.5s ⚠️ +177ms
buildDurationCached 7.2s 6.2s N/A
nodeModulesSize 174 MB 174 MB ✓
nextStartRea..uration (ms) 496ms 497ms N/A
Client Bundles (main, webpack)
vercel/next.js canary philwolstenholme/next.js 57126 Change
199-HASH.js gzip 27.6 kB 27.6 kB ✓
3f784ff6-HASH.js gzip 53.3 kB 53.3 kB ✓
99.HASH.js gzip 182 B 182 B ✓
framework-HASH.js gzip 45.3 kB 45.3 kB ✓
main-app-HASH.js gzip 254 B 252 B N/A
main-HASH.js gzip 32.9 kB 32.9 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 126 kB 126 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary philwolstenholme/next.js 57126 Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary philwolstenholme/next.js 57126 Change
_app-HASH.js gzip 206 B 205 B N/A
_error-HASH.js gzip 182 B 180 B N/A
amp-HASH.js gzip 506 B 505 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.57 kB 2.57 kB N/A
edge-ssr-HASH.js gzip 260 B 259 B N/A
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 369 B 369 B ✓
image-HASH.js gzip 4.36 kB 4.36 kB N/A
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.64 kB 2.63 kB N/A
routerDirect..HASH.js gzip 312 B 311 B N/A
script-HASH.js gzip 385 B 384 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 1.08 kB 1.08 kB ✓
Client Build Manifests
vercel/next.js canary philwolstenholme/next.js 57126 Change
_buildManifest.js gzip 484 B 482 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary philwolstenholme/next.js 57126 Change
index.html gzip 527 B 529 B N/A
link.html gzip 542 B 541 B N/A
withRouter.html gzip 525 B 525 B ✓
Overall change 525 B 525 B ✓
Edge SSR bundle Size
vercel/next.js canary philwolstenholme/next.js 57126 Change
edge-ssr.js gzip 93.9 kB 93.9 kB N/A
page.js gzip 155 kB 155 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary philwolstenholme/next.js 57126 Change
middleware-b..fest.js gzip 623 B 624 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 22.9 kB 22.9 kB ✓
edge-runtime..pack.js gzip 1.92 kB 1.92 kB ✓
Overall change 24.8 kB 24.8 kB ✓
Commit: c4e4277

@kodiakhq kodiakhq bot merged commit aa1ee59 into vercel:canary Oct 20, 2023
@philwolstenholme philwolstenholme deleted the 57126 branch October 21, 2023 09:38
@github-actions github-actions bot added the locked label Nov 4, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balazsorban44 balazsorban44 balazsorban44 approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

@feedthejim feedthejim Awaiting requested review from feedthejim

@ztanner ztanner Awaiting requested review from ztanner

@wyattjoh wyattjoh Awaiting requested review from wyattjoh

Assignees
No one assigned
Labels
locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<GoogleTagManager> types in @next/third-parties seem incorrect compared to e2e test usage
3 participants
@philwolstenholme @ijjk @balazsorban44