Import turbo daily integration test workflows #57083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
padmaia
reviewed
Oct 19, 2023
| # First, build next-dev and Next.js both to execute across tests. | ||
| setup_nextjs: | ||
| name: Setup Next.js build | ||
| uses: ./.github/workflows/setup-nextjs-build.yml |
There was a problem hiding this comment.
Doesn't look like this exists in this repo, checking to see if we even need it...
There was a problem hiding this comment.
this probably should use next.js's existing workflow to setup next.js build.
There was a problem hiding this comment.
hmm looks like there's some other jobs/handling in that workflow so copied it over for now
There was a problem hiding this comment.
I mean eventually for the followup, not immediately in this PR
padmaia
reviewed
Oct 19, 2023
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
|
padmaia
reviewed
Oct 19, 2023
kwonoj
reviewed
Oct 19, 2023
| name: Execute Next.js integration workflow | ||
| permissions: | ||
| pull-requests: write | ||
| uses: ./.github/workflows/nextjs-integration-test.yml |
There was a problem hiding this comment.
prolly as followup, this may able to use existing workflow in next.js repo itself - most of these setups are mimic to port what next.js already have.
kwonoj
reviewed
Oct 19, 2023
| workflow_dispatch: | ||
| inputs: | ||
| version: | ||
| description: Next.js version, sha, branch to test |
kwonoj
reviewed
Oct 19, 2023
| # We'll tag this to the Turbopack service, not the next.js | ||
| DD_ENV=ci datadog-ci junit upload --tags test.type:turbopack.daily --service Turbopack test | ||
|
|
||
| # For the debugging purpose, upload the test trace to github artifact. |
There was a problem hiding this comment.
not sure if we need this or not.
sokra
reviewed
Oct 20, 2023
Comment on lines
33
to
41
| # Upload test results to branch. | ||
| # upload_test_results: | ||
| # name: Upload test results | ||
| # needs: [next_js_integration] | ||
| # if: ${{ github.event_name == 'schedule' }} && always() | ||
| # uses: ./.github/workflows/upload-nextjs-integration-test-results.yml | ||
| # secrets: inherit | ||
| # with: | ||
| # is_main_branch: true |
There was a problem hiding this comment.
We use that JSON file as source for the build-turbopack-tests-manifest.js import and for the website maia did. So we need that data pushed.
b39325d to
d0cbfd1
Compare
timneutkens
approved these changes
Oct 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed this imports our daily turbo integration tests workflow into the Next.js repo