Skip to content

Conversation

feedthejim
Copy link
Contributor

No description provided.

ztanner
ztanner previously approved these changes Oct 26, 2023
@ijjk
Copy link
Member

ijjk commented Oct 26, 2023

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js feedthejim/oops Change
buildDuration 10.1s 10.3s ⚠️ +132ms
buildDurationCached 5.9s 5.9s N/A
nodeModulesSize 175 MB 175 MB N/A
nextStartRea..uration (ms) 412ms 413ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js feedthejim/oops Change
199-HASH.js gzip 32.3 kB 32.4 kB N/A
3f784ff6-HASH.js gzip 53.2 kB 53.2 kB N/A
99.HASH.js gzip 182 B 182 B
framework-HASH.js gzip 45.5 kB 45.5 kB
main-app-HASH.js gzip 250 B 252 B N/A
main-HASH.js gzip 35.3 kB 35.4 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 45.7 kB 45.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js feedthejim/oops Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js feedthejim/oops Change
_app-HASH.js gzip 206 B 205 B N/A
_error-HASH.js gzip 182 B 180 B N/A
amp-HASH.js gzip 506 B 505 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.59 kB 2.59 kB
edge-ssr-HASH.js gzip 260 B 259 B N/A
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.38 kB 4.38 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 316 B 318 B N/A
script-HASH.js gzip 385 B 384 B N/A
withRouter-HASH.js gzip 319 B 319 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.99 kB 3.99 kB
Client Build Manifests
vercel/next.js canary vercel/next.js feedthejim/oops Change
_buildManifest.js gzip 484 B 482 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js feedthejim/oops Change
index.html gzip 529 B 530 B N/A
link.html gzip 541 B 542 B N/A
withRouter.html gzip 523 B 523 B
Overall change 523 B 523 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js feedthejim/oops Change
edge-ssr.js gzip 96 kB 96 kB N/A
page.js gzip 140 kB 140 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js feedthejim/oops Change
middleware-b..fest.js gzip 624 B 623 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 25.6 kB 25.6 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 1.92 kB 1.92 kB
Commit: 83ec918

@ijjk
Copy link
Member

ijjk commented Oct 26, 2023

Failing test suites

Commit: 83ec918

pnpm test-dev test/development/basic/gssp-ssr-change-reloading/test/index.test.ts

  • GS(S)P Server-Side Change Reloading > should show indicator when re-fetching data
  • GS(S)P Server-Side Change Reloading > should update page when getStaticPaths is changed only
Expand output

● GS(S)P Server-Side Change Reloading › should show indicator when re-fetching data

TIMED OUT: 2

1

undefined

  626 |
  627 |   if (hardError) {
> 628 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr)
      |           ^
  629 |   }
  630 |   return false
  631 | }

  at check (lib/next-test-utils.ts:628:11)
  at Object.<anonymous> (development/basic/gssp-ssr-change-reloading/test/index.test.ts:100:5)

● GS(S)P Server-Side Change Reloading › should update page when getStaticPaths is changed only

expect(received).toBe(expected) // Object.is equality

Expected: 1
Received: 2

  119 |
  120 |     const props = JSON.parse(await browser.elementByCss('#props').text())
> 121 |     expect(props.count).toBe(1)
      |                         ^
  122 |
  123 |     const page = 'pages/gsp-blog/[post].js'
  124 |     const originalContent = await next.readFile(page)

  at Object.toBe (development/basic/gssp-ssr-change-reloading/test/index.test.ts:121:25)

Read more about building and testing Next.js in contributing.md.

@feedthejim feedthejim merged commit 6b6eddb into canary Oct 26, 2023
@feedthejim feedthejim deleted the feedthejim/oops branch October 26, 2023 02:51
@github-actions github-actions bot added the locked label Nov 9, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants