Expose Experimental Taint APIs #56507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: scheduler@0.0.0-experimental-d900fadbf-20230929, scheduler@0.24.0-canary-d900fadbf-20230929 |
Tests Passed |
Stats from current PRDefault Build (Increase detected
|
| vercel/next.js canary | sebmarkbage/next.js taint | Change | |
|---|---|---|---|
| buildDuration | 10.7s | 10.7s | N/A |
| buildDurationCached | 6.2s | 6.2s | N/A |
| nodeModulesSize | 174 MB | 174 MB | |
| nextStartRea..uration (ms) | 499ms | 494ms | N/A |
Client Bundles (main, webpack)
| vercel/next.js canary | sebmarkbage/next.js taint | Change | |
|---|---|---|---|
| 199-HASH.js gzip | 27.5 kB | 27.5 kB | ✓ |
| 3f784ff6-HASH.js gzip | 53.3 kB | 53.3 kB | ✓ |
| 99.HASH.js gzip | 182 B | 182 B | ✓ |
| framework-HASH.js gzip | 45.3 kB | 45.3 kB | ✓ |
| main-app-HASH.js gzip | 254 B | 251 B | N/A |
| main-HASH.js gzip | 32.9 kB | 32.9 kB | N/A |
| webpack-HASH.js gzip | 1.75 kB | 1.75 kB | N/A |
| Overall change | 126 kB | 126 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | sebmarkbage/next.js taint | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages
| vercel/next.js canary | sebmarkbage/next.js taint | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 206 B | 205 B | N/A |
| _error-HASH.js gzip | 182 B | 180 B | N/A |
| amp-HASH.js gzip | 506 B | 505 B | N/A |
| css-HASH.js gzip | 322 B | 323 B | N/A |
| dynamic-HASH.js gzip | 2.57 kB | 2.57 kB | N/A |
| edge-ssr-HASH.js gzip | 260 B | 259 B | N/A |
| head-HASH.js gzip | 350 B | 350 B | ✓ |
| hooks-HASH.js gzip | 369 B | 369 B | ✓ |
| image-HASH.js gzip | 4.36 kB | 4.36 kB | N/A |
| index-HASH.js gzip | 256 B | 256 B | ✓ |
| link-HASH.js gzip | 2.64 kB | 2.63 kB | N/A |
| routerDirect..HASH.js gzip | 312 B | 311 B | N/A |
| script-HASH.js gzip | 385 B | 384 B | N/A |
| withRouter-HASH.js gzip | 307 B | 308 B | N/A |
| 1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
| Overall change | 1.08 kB | 1.08 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | sebmarkbage/next.js taint | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 484 B | 482 B | N/A |
| Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | sebmarkbage/next.js taint | Change | |
|---|---|---|---|
| index.html gzip | 528 B | 529 B | N/A |
| link.html gzip | 543 B | 542 B | N/A |
| withRouter.html gzip | 524 B | 524 B | ✓ |
| Overall change | 524 B | 524 B | ✓ |
Edge SSR bundle Size Overall increase ⚠️
| vercel/next.js canary | sebmarkbage/next.js taint | Change | |
|---|---|---|---|
| edge-ssr.js gzip | 93.7 kB | 93.7 kB | N/A |
| page.js gzip | 155 kB | 155 kB | |
| Overall change | 155 kB | 155 kB |
Middleware size
| vercel/next.js canary | sebmarkbage/next.js taint | Change | |
|---|---|---|---|
| middleware-b..fest.js gzip | 623 B | 625 B | N/A |
| middleware-r..fest.js gzip | 150 B | 151 B | N/A |
| middleware.js gzip | 22.5 kB | 22.5 kB | N/A |
| edge-runtime..pack.js gzip | 1.92 kB | 1.92 kB | ✓ |
| Overall change | 1.92 kB | 1.92 kB | ✓ |
Diff details
Diff for page.js
Diff too large to display
Diff for edge-ssr.js
Diff too large to display
sebmarkbage
commented
Oct 6, 2023
3a9e513 to
69b3eee
Compare
This pretends that they always exist so that they error at runtime if we use them without the flag check.
feedthejim
reviewed
Oct 19, 2023
feedthejim
approved these changes
Oct 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes the new experimental Taint APIs using the
taintflag which enables experimental React.As an example for how we can use it, I use it to taint
process.envwith a better error message. I'm not sure where this should live since it's a global init but it needs access to the global config. It's unnecessary to retaint it for every render but not sure if there's a better place for it.