Skip to content

Conversation

SukkaW
Copy link
Contributor

@SukkaW SukkaW commented Jul 29, 2023

The PR fixes #50208.

Previously, the terserOptions is not properly passed to the swc:

  • swc expects: { mangle, compress, sourceMap }
  • swc receives from Next.js' terser-webpack-plugin: { sourceMap, terserOptions: { compress, mangle } }

The PR fixes that.

@SukkaW SukkaW requested review from timneutkens, ijjk, shuding, huozhi and a team as code owners July 29, 2023 09:31
@ijjk
Copy link
Member

ijjk commented Jul 29, 2023

Allow CI Workflow Run

  • approve CI run for commit: 9f3da90

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@SukkaW
Copy link
Contributor Author

SukkaW commented Aug 12, 2023

@feedthejim Kindly request your attention with a friendly ping. My PR has been open for two weeks.

Since Next.js' --no-mangling and MANGING_DEBUG was first introduced by you, I would greatly appreciate it if you could spare some time to review my PR, at your convenience, and provide your valuable feedback.

@timneutkens timneutkens added the CI approved Approve running CI for fork label Aug 21, 2023
@SukkaW
Copy link
Contributor Author

SukkaW commented Oct 2, 2023

The PR has been superseded by #56281. Closing.

@SukkaW SukkaW closed this Oct 2, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2023
@SukkaW SukkaW deleted the fix-no-mangling branch October 24, 2023 08:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI approved Approve running CI for fork locked type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

__NEXT_MANGLING_DEBUG resp. --no-mangling do not work with swcMinify: true (per next config)
3 participants