Skip to content

Update Cosmic CMS Example: cosmicjs package to v4.1.7, update queries #37693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 20, 2022
Merged

Update Cosmic CMS Example: cosmicjs package to v4.1.7, update queries #37693

merged 4 commits into from
Jun 20, 2022

Conversation

tonyspiro
Copy link
Contributor

Thank you 🙏🏻

@ijjk ijjk added the examples Issue was opened via the examples template. label Jun 14, 2022
balazsorban44
balazsorban44 reviewed Jun 14, 2022
View reviewed changes
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

This seems to be a good opportunity to upgrade all the other packages to their latest ones as well. 👍

Would you be open to converting this example to TypeScript? (If not, that's fine!)

balazsorban44
balazsorban44 approved these changes Jun 20, 2022
View reviewed changes
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but feel free to revisit in a different PR and upgrade other dependencies, or even convert the example to TypeScript, as this is our preferred default now. 👍

See: https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples

@kodiakhq kodiakhq bot merged commit 6a39d51 into vercel:canary Jun 20, 2022
@tonyspiro
Copy link
Contributor Author

Thank you @balazsorban44 we are actually working on these updates. We'll issue another PR when it's ready.

@tonyspiro tonyspiro deleted the cosmic-cms-example-update branch June 20, 2022 17:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balazsorban44 balazsorban44 balazsorban44 approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@leerob leerob Awaiting requested review from leerob

@steven-tey steven-tey Awaiting requested review from steven-tey

Assignees
No one assigned
Labels
examples Issue was opened via the examples template.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tonyspiro @balazsorban44 @ijjk