Skip to content

Add final newline to package-lock.json #36813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 10, 2022
Merged

Add final newline to package-lock.json #36813

merged 2 commits into from
May 10, 2022

Conversation

remcohaszing
Copy link
Contributor

This aligns the output with what npm outputs. Without this change,
Next.js causes unwanted changes in package-lock.json.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@remcohaszing
Add final newline to package-lock.json
8a9cb68 
This aligns the output with what npm outputs. Without this change,
Next.js causes unwanted changes in package-lock.json.
ijjk
ijjk approved these changes May 10, 2022
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijjk
Copy link
Member

ijjk commented May 10, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary remcohaszing/next.js package-lock-eol Change
buildDuration 18.3s 19.2s ⚠️ +970ms
buildDurationCached 7.4s 7.5s ⚠️ +138ms
nodeModulesSize 475 MB 475 MB ⚠️ +17 B
Page Load Tests Overall increase ✓
vercel/next.js canary remcohaszing/next.js package-lock-eol Change
/ failed reqs 0 0 ✓
/ total time (seconds) 4.869 4.987 ⚠️ +0.12
/ avg req/sec 513.45 501.27 ⚠️ -12.18
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.828 1.775 -0.05
/error-in-render avg req/sec 1367.75 1408.1 +40.35
Client Bundles (main, webpack)
vercel/next.js canary remcohaszing/next.js package-lock-eol Change
925.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 28.8 kB 28.8 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 72.5 kB 72.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary remcohaszing/next.js package-lock-eol Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary remcohaszing/next.js package-lock-eol Change
_app-HASH.js gzip 1.36 kB 1.36 kB ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 308 B 308 B ✓
css-HASH.js gzip 327 B 327 B ✓
dynamic-HASH.js gzip 2.69 kB 2.69 kB ✓
head-HASH.js gzip 359 B 359 B ✓
hooks-HASH.js gzip 920 B 920 B ✓
image-HASH.js gzip 5.7 kB 5.7 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.64 kB 2.64 kB ✓
routerDirect..HASH.js gzip 320 B 320 B ✓
script-HASH.js gzip 391 B 391 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 15.9 kB 15.9 kB ✓
Client Build Manifests
vercel/next.js canary remcohaszing/next.js package-lock-eol Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary remcohaszing/next.js package-lock-eol Change
index.html gzip 532 B 532 B ✓
link.html gzip 546 B 546 B ✓
withRouter.html gzip 528 B 528 B ✓
Overall change 1.61 kB 1.61 kB ✓
Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary remcohaszing/next.js package-lock-eol Change
buildDuration 22.3s 23.3s ⚠️ +986ms
buildDurationCached 7.7s 8.1s ⚠️ +437ms
nodeModulesSize 475 MB 475 MB ⚠️ +17 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary remcohaszing/next.js package-lock-eol Change
/ failed reqs 0 0 ✓
/ total time (seconds) 5.476 5.665 ⚠️ +0.19
/ avg req/sec 456.52 441.32 ⚠️ -15.2
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.071 2.156 ⚠️ +0.08
/error-in-render avg req/sec 1206.9 1159.41 ⚠️ -47.49
Client Bundles (main, webpack)
vercel/next.js canary remcohaszing/next.js package-lock-eol Change
925.HASH.js gzip 178 B 178 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 29.2 kB 29.2 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 73.1 kB 73.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary remcohaszing/next.js package-lock-eol Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary remcohaszing/next.js package-lock-eol Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 179 B 179 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 324 B 324 B ✓
dynamic-HASH.js gzip 2.71 kB 2.71 kB ✓
head-HASH.js gzip 357 B 357 B ✓
hooks-HASH.js gzip 921 B 921 B ✓
image-HASH.js gzip 5.79 kB 5.79 kB ✓
index-HASH.js gzip 261 B 261 B ✓
link-HASH.js gzip 2.76 kB 2.76 kB ✓
routerDirect..HASH.js gzip 322 B 322 B ✓
script-HASH.js gzip 392 B 392 B ✓
withRouter-HASH.js gzip 317 B 317 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 16.1 kB 16.1 kB ✓
Client Build Manifests
vercel/next.js canary remcohaszing/next.js package-lock-eol Change
_buildManifest.js gzip 456 B 456 B ✓
Overall change 456 B 456 B ✓
Rendered Page Sizes
vercel/next.js canary remcohaszing/next.js package-lock-eol Change
index.html gzip 529 B 529 B ✓
link.html gzip 543 B 543 B ✓
withRouter.html gzip 526 B 526 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: 0e259c6

@kodiakhq kodiakhq bot merged commit 8f9296c into vercel:canary May 10, 2022
This was referenced May 11, 2022
Closed
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2022
@remcohaszing remcohaszing deleted the package-lock-eol branch October 20, 2022 08:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@remcohaszing @ijjk