Skip to content

Added with-particles template #35471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Jun 22, 2022
Merged

Added with-particles template #35471

merged 17 commits into from
Jun 22, 2022

Conversation

matteobruni
Copy link
Contributor

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added the examples Issue was opened via the examples template. label Mar 20, 2022
@matteobruni matteobruni requested a review from balazsorban44 as a code owner May 8, 2022 15:29
balazsorban44
balazsorban44 reviewed May 9, 2022
View reviewed changes
balazsorban44
balazsorban44 reviewed May 9, 2022
View reviewed changes
balazsorban44
balazsorban44 reviewed May 9, 2022
View reviewed changes
matteobruni and others added 4 commits May 9, 2022 12:46
@matteobruni @balazsorban44
Update examples/with-particles/package.json
89e6a27 
Co-authored-by: Balázs Orbán <info@balazsorban.com>
@matteobruni @balazsorban44
Update examples/with-particles/package.json
3286052 
Co-authored-by: Balázs Orbán <info@balazsorban.com>
@matteobruni
Merge branch 'canary' into canary
7cf0199
@matteobruni
Update README.md
09f0809
balazsorban44
balazsorban44 requested changes May 9, 2022
View reviewed changes
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I added some small comments.

Another question, what's the correct way of referring to the library? I see the directory was named with-particles, but the package is called react-tsparticles, the website https://particles.js.org/ says "TS Particles" (while the page title is tsParticles).

The reason I'm asking is that there is a https://vincentgarreau.com/particles.js/ so to not confuse developers, maybe we should call the directory with-tsparticles? What do you think?

@matteobruni matteobruni requested a review from balazsorban44 May 9, 2022 10:57
balazsorban44
balazsorban44 requested changes May 10, 2022
View reviewed changes
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing my comments, could we also convert this example to TypeScript?

@matteobruni
Copy link
Contributor Author

matteobruni commented May 10, 2022 •
edited
Loading

Thanks for fixing my comments, could we also convert this example to TypeScript?

@balazsorban44 Another example or just convert this one to TS? It's not a problem either way

@balazsorban44
Copy link
Member

Converting this to TypeScript should be enough. 👍

@matteobruni
Copy link
Contributor Author

Converting this to TypeScript should be enough. 👍

Converted 👍

@matteobruni matteobruni requested a review from balazsorban44 May 13, 2022 14:34
balazsorban44
balazsorban44 approved these changes Jun 22, 2022
View reviewed changes
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kodiakhq kodiakhq bot merged commit cf3ba27 into vercel:canary Jun 22, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balazsorban44 balazsorban44 balazsorban44 approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@leerob leerob Awaiting requested review from leerob

@steven-tey steven-tey Awaiting requested review from steven-tey

Assignees
No one assigned
Labels
examples Issue was opened via the examples template.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matteobruni @balazsorban44 @ijjk