Skip to content

next-swc: Improve error message for nested styled jsx tags #33805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 22, 2022
Merged

next-swc: Improve error message for nested styled jsx tags #33805

merged 6 commits into from
May 22, 2022

Conversation

hanneslund
Copy link
Contributor

@hanneslund hanneslund commented Jan 30, 2022 •
edited
Loading

Before
image

After
image

@ijjk

This comment has been minimized.

Sign in to view
@hanneslund hanneslund force-pushed the next-swc-nested-styled-jsx-tags branch from c5c1273 to eb34caf Compare January 31, 2022 07:54
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member

ijjk commented Mar 13, 2022 •
edited
Loading

Stats from current PR

Default Build (Decrease detected ✓)
General
vercel/next.js canary hanneslund/next.js next-swc-nested-styled-jsx-tags Change
buildDuration 16.4s 16.3s -24ms
buildDurationCached 6.5s 6.7s ⚠️ +278ms
nodeModulesSize 479 MB 479 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary hanneslund/next.js next-swc-nested-styled-jsx-tags Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.934 3.958 ⚠️ +0.02
/ avg req/sec 635.54 631.66 ⚠️ -3.88
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.373 1.375 0
/error-in-render avg req/sec 1820.55 1818.55 ⚠️ -2
Client Bundles (main, webpack)
vercel/next.js canary hanneslund/next.js next-swc-nested-styled-jsx-tags Change
925.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 29.2 kB 29.2 kB ✓
webpack-HASH.js gzip 1.54 kB 1.54 kB ✓
Overall change 72.9 kB 72.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary hanneslund/next.js next-swc-nested-styled-jsx-tags Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary hanneslund/next.js next-swc-nested-styled-jsx-tags Change
_app-HASH.js gzip 1.36 kB 1.36 kB ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 308 B 308 B ✓
css-HASH.js gzip 327 B 327 B ✓
dynamic-HASH.js gzip 2.71 kB 2.71 kB ✓
head-HASH.js gzip 359 B 359 B ✓
hooks-HASH.js gzip 920 B 920 B ✓
image-HASH.js gzip 5.73 kB 5.73 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.65 kB 2.65 kB ✓
routerDirect..HASH.js gzip 320 B 320 B ✓
script-HASH.js gzip 391 B 391 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 16 kB 16 kB ✓
Client Build Manifests
vercel/next.js canary hanneslund/next.js next-swc-nested-styled-jsx-tags Change
_buildManifest.js gzip 458 B 458 B ✓
Overall change 458 B 458 B ✓
Rendered Page Sizes
vercel/next.js canary hanneslund/next.js next-swc-nested-styled-jsx-tags Change
index.html gzip 533 B 533 B ✓
link.html gzip 547 B 547 B ✓
withRouter.html gzip 528 B 528 B ✓
Overall change 1.61 kB 1.61 kB ✓
Default Build with SWC (Decrease detected ✓)
General
vercel/next.js canary hanneslund/next.js next-swc-nested-styled-jsx-tags Change
buildDuration 18.5s 18.7s ⚠️ +175ms
buildDurationCached 6.5s 6.4s -86ms
nodeModulesSize 479 MB 479 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary hanneslund/next.js next-swc-nested-styled-jsx-tags Change
/ failed reqs 0 0 ✓
/ total time (seconds) 4.028 4.014 -0.01
/ avg req/sec 620.66 622.76 +2.1
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.383 1.391 ⚠️ +0.01
/error-in-render avg req/sec 1807.38 1797.71 ⚠️ -9.67
Client Bundles (main, webpack)
vercel/next.js canary hanneslund/next.js next-swc-nested-styled-jsx-tags Change
925.HASH.js gzip 178 B 178 B ✓
framework-HASH.js gzip 42.7 kB 42.7 kB ✓
main-HASH.js gzip 29.6 kB 29.6 kB ✓
webpack-HASH.js gzip 1.54 kB 1.54 kB ✓
Overall change 74 kB 74 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary hanneslund/next.js next-swc-nested-styled-jsx-tags Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary hanneslund/next.js next-swc-nested-styled-jsx-tags Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 179 B 179 B ✓
amp-HASH.js gzip 311 B 311 B ✓
css-HASH.js gzip 324 B 324 B ✓
dynamic-HASH.js gzip 2.89 kB 2.89 kB ✓
head-HASH.js gzip 357 B 357 B ✓
hooks-HASH.js gzip 920 B 920 B ✓
image-HASH.js gzip 5.82 kB 5.82 kB ✓
index-HASH.js gzip 261 B 261 B ✓
link-HASH.js gzip 2.78 kB 2.78 kB ✓
routerDirect..HASH.js gzip 322 B 322 B ✓
script-HASH.js gzip 392 B 392 B ✓
withRouter-HASH.js gzip 317 B 317 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 16.3 kB 16.3 kB ✓
Client Build Manifests
vercel/next.js canary hanneslund/next.js next-swc-nested-styled-jsx-tags Change
_buildManifest.js gzip 457 B 457 B ✓
Overall change 457 B 457 B ✓
Rendered Page Sizes
vercel/next.js canary hanneslund/next.js next-swc-nested-styled-jsx-tags Change
index.html gzip 532 B 532 B ✓
link.html gzip 547 B 547 B ✓
withRouter.html gzip 529 B 529 B ✓
Overall change 1.61 kB 1.61 kB ✓
Commit: fb13ede

ijjk added 3 commits May 22, 2022 16:48
@ijjk
Merge branch 'canary' into next-swc-nested-styled-jsx-tags
0142989 
# Conflicts:
#	errors/manifest.json
#	packages/next-swc/crates/styled_jsx/tests/errors/nested-style-tags/input.js
#	packages/next-swc/crates/styled_jsx/tests/errors/nested-style-tags/output.js
#	packages/next-swc/crates/styled_jsx/tests/errors/nested-style-tags/output.stderr
@ijjk
Merge branch 'canary' into next-swc-nested-styled-jsx-tags
447037e
@ijjk
fix merge
2420c4f
ijjk
ijjk approved these changes May 22, 2022
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@kodiakhq kodiakhq bot merged commit 3186645 into vercel:canary May 22, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2022
@hanneslund hanneslund deleted the next-swc-nested-styled-jsx-tags branch September 8, 2022 06:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@huozhi huozhi Awaiting requested review from huozhi

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanneslund @ijjk