Skip to content

Resolve streaming data for flight requests #32010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2021
Merged

Resolve streaming data for flight requests #32010

merged 1 commit into from
Dec 1, 2021

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Dec 1, 2021 •
edited
Loading

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Dec 1, 2021
@huozhi huozhi force-pushed the fix/streaming-data branch from e0ae379 to 83075fb Compare December 1, 2021 15:07
@ijjk
Copy link
Member

ijjk commented Dec 1, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js fix/streaming-data Change
buildDuration 24s 24.3s ⚠️ +335ms
buildDurationCached 4.2s 4.2s ⚠️ +41ms
nodeModulesSize 347 MB 347 MB ⚠️ +137 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js fix/streaming-data Change
/ failed reqs 0 0 ✓
/ total time (seconds) 4.082 4.156 ⚠️ +0.07
/ avg req/sec 612.42 601.58 ⚠️ -10.84
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.101 2.24 ⚠️ +0.14
/error-in-render avg req/sec 1190.13 1115.91 ⚠️ -74.22
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js fix/streaming-data Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 28.4 kB 28.4 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 72.3 kB 72.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js fix/streaming-data Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary huozhi/next.js fix/streaming-data Change
_app-HASH.js gzip 1.37 kB 1.37 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.38 kB 2.38 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 635 B 635 B ✓
image-HASH.js gzip 4.49 kB 4.49 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.87 kB 1.87 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 13.3 kB 13.3 kB ✓
Client Build Manifests
vercel/next.js canary huozhi/next.js fix/streaming-data Change
_buildManifest.js gzip 460 B 460 B ✓
Overall change 460 B 460 B ✓
Rendered Page Sizes
vercel/next.js canary huozhi/next.js fix/streaming-data Change
index.html gzip 532 B 532 B ✓
link.html gzip 545 B 545 B ✓
withRouter.html gzip 526 B 526 B ✓
Overall change 1.6 kB 1.6 kB ✓
Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js fix/streaming-data Change
buildDuration 26.2s 25.7s -516ms
buildDurationCached 4.3s 4.3s ⚠️ +25ms
nodeModulesSize 347 MB 347 MB ⚠️ +137 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js fix/streaming-data Change
/ failed reqs 0 0 ✓
/ total time (seconds) 4.081 3.984 -0.1
/ avg req/sec 612.56 627.49 +14.93
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.065 2.136 ⚠️ +0.07
/error-in-render avg req/sec 1210.46 1170.56 ⚠️ -39.9
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js fix/streaming-data Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 28.6 kB 28.6 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 72.5 kB 72.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js fix/streaming-data Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary huozhi/next.js fix/streaming-data Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.37 kB 2.37 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 622 B 622 B ✓
image-HASH.js gzip 4.53 kB 4.53 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 1.91 kB 1.91 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 13.3 kB 13.3 kB ✓
Client Build Manifests
vercel/next.js canary huozhi/next.js fix/streaming-data Change
_buildManifest.js gzip 458 B 458 B ✓
Overall change 458 B 458 B ✓
Rendered Page Sizes
vercel/next.js canary huozhi/next.js fix/streaming-data Change
index.html gzip 532 B 532 B ✓
link.html gzip 545 B 545 B ✓
withRouter.html gzip 526 B 526 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: 83075fb

@kodiakhq kodiakhq bot merged commit 928c779 into vercel:canary Dec 1, 2021
@huozhi huozhi deleted the fix/streaming-data branch December 7, 2021 17:13
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shuding shuding shuding approved these changes

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huozhi @ijjk @shuding