Skip to content

update webpack-sources to 3.2.0 for bugfixes and performance #27673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 3, 2021
Merged

update webpack-sources to 3.2.0 for bugfixes and performance #27673

merged 3 commits into from
Aug 3, 2021

Conversation

sokra
Copy link
Member

@sokra sokra commented Aug 2, 2021

No description provided.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Aug 2, 2021
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@sokra sokra force-pushed the webpack/upgrade branch from 04f5fff to dde51dc Compare August 2, 2021 12:59
@ijjk
Copy link
Member

ijjk commented Aug 2, 2021

Failing test suites

Commit: dde51dc

test/unit/webpack-config-overrides.unit.test.js

Expand output

● Test suite failed to run

/home/runner/work/next.js/next.js/packages/next/dist/build/webpack/config/blocks/css/index.js: No element indexed by 1

  at ArraySet_at [as at] (../node_modules/jest-config/node_modules/source-map/lib/array-set.js:109:9)
      at Array.map (<anonymous>)
      at run.next (<anonymous>)

@sokra sokra force-pushed the webpack/upgrade branch from 92e557f to b104f41 Compare August 2, 2021 21:23
@sokra sokra force-pushed the webpack/upgrade branch from b104f41 to 166a872 Compare August 2, 2021 21:27
@ijjk

This comment has been minimized.

Sign in to view
@sokra sokra marked this pull request as ready for review August 2, 2021 22:07
@ijjk
Copy link
Member

ijjk commented Aug 2, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js webpack/upgrade Change
buildDuration 16.5s 16.5s ⚠️ +40ms
buildDurationCached 3.7s 3.7s -18ms
nodeModulesSize 50.1 MB 50.1 MB ⚠️ +13.4 kB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js webpack/upgrade Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.002 2.994 -0.01
/ avg req/sec 832.91 834.97 +2.06
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.827 1.815 -0.01
/error-in-render avg req/sec 1368.46 1377.33 +8.87
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js webpack/upgrade Change
745.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 22.8 kB 22.8 kB ✓
webpack-HASH.js gzip 1.5 kB 1.5 kB ✓
Overall change 66.7 kB 66.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js webpack/upgrade Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages Overall increase ⚠️
vercel/next.js canary vercel/next.js webpack/upgrade Change
_app-HASH.js gzip 980 B 980 B ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 329 B 329 B ✓
dynamic-HASH.js gzip 2.52 kB 2.52 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 903 B 904 B ⚠️ +1 B
image-HASH.js gzip 4.13 kB 4.13 kB ✓
index-HASH.js gzip 261 B 261 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 319 B 319 B ✓
script-HASH.js gzip 387 B 387 B ✓
withRouter-HASH.js gzip 320 B 320 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 12.8 kB 12.8 kB ⚠️ +1 B
Client Build Manifests Overall increase ⚠️
vercel/next.js canary vercel/next.js webpack/upgrade Change
_buildManifest.js gzip 491 B 492 B ⚠️ +1 B
Overall change 491 B 492 B ⚠️ +1 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js webpack/upgrade Change
index.html gzip 530 B 530 B ✓
link.html gzip 542 B 542 B ✓
withRouter.html gzip 524 B 524 B ✓
Overall change 1.6 kB 1.6 kB ✓

Diffs

Diff for _buildManifest.js 
@@ -14,7 +14,7 @@ self.__BUILD_MANIFEST = {
   ],
   "/head": ["static\u002Fchunks\u002Fpages\u002Fhead-b93e7fccd3af1c72154e.js"],
   "/hooks": [
-    "static\u002Fchunks\u002Fpages\u002Fhooks-5bd5f4a70a656f6678c4.js"
+    "static\u002Fchunks\u002Fpages\u002Fhooks-1cb3a46057c08067a973.js"
   ],
   "/image": [
     "static\u002Fchunks\u002Fpages\u002Fimage-1ad88e6dd5c62e24187c.js"
Diff for hooks-HASH.js 
@@ -1,7 +1,7 @@
 (self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
   [757],
   {
-    /***/ 3050: /***/ function(
+    /***/ 9976: /***/ function(
       __unused_webpack_module,
       __webpack_exports__,
       __webpack_require__
@@ -142,7 +142,7 @@
       (window.__NEXT_P = window.__NEXT_P || []).push([
         "/hooks",
         function() {
-          return __webpack_require__(3050);
+          return __webpack_require__(9976);
         }
       ]);
Webpack 4 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js webpack/upgrade Change
buildDuration 13.4s 13.2s -181ms
buildDurationCached 5.1s 5.1s ⚠️ +8ms
nodeModulesSize 50.1 MB 50.1 MB ⚠️ +13.4 kB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js webpack/upgrade Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.979 2.992 ⚠️ +0.01
/ avg req/sec 839.34 835.6 ⚠️ -3.74
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.882 1.796 -0.09
/error-in-render avg req/sec 1328.06 1391.86 +63.8
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js webpack/upgrade Change
17.HASH.js gzip 185 B 185 B ✓
677f882d2ed8..HASH.js gzip 13.8 kB 13.8 kB ✓
framework.HASH.js gzip 41.9 kB 41.9 kB ✓
main-HASH.js gzip 10.6 kB 10.6 kB ✓
webpack-HASH.js gzip 1.19 kB 1.19 kB ✓
Overall change 67.7 kB 67.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js webpack/upgrade Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary vercel/next.js webpack/upgrade Change
_app-HASH.js gzip 965 B 965 B ✓
_error-HASH.js gzip 3.74 kB 3.74 kB ✓
amp-HASH.js gzip 552 B 552 B ✓
css-HASH.js gzip 333 B 333 B ✓
dynamic-HASH.js gzip 2.71 kB 2.71 kB ✓
head-HASH.js gzip 2.97 kB 2.97 kB ✓
hooks-HASH.js gzip 911 B 911 B ✓
index-HASH.js gzip 231 B 231 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 298 B 298 B ✓
script-HASH.js gzip 2.94 kB 2.94 kB ✓
withRouter-HASH.js gzip 294 B 294 B ✓
e025d2764813..52f.css gzip 125 B 125 B ✓
Overall change 17.7 kB 17.7 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js webpack/upgrade Change
_buildManifest.js gzip 499 B 499 B ✓
Overall change 499 B 499 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js webpack/upgrade Change
index.html gzip 578 B 578 B ✓
link.html gzip 591 B 591 B ✓
withRouter.html gzip 571 B 571 B ✓
Overall change 1.74 kB 1.74 kB ✓
Commit: e7eef92

@kodiakhq kodiakhq bot merged commit b36c66a into canary Aug 3, 2021
@kodiakhq kodiakhq bot deleted the webpack/upgrade branch August 3, 2021 00:01
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Aug 19, 2021
@sokra
update webpack-sources to 3.2.0 for bugfixes and performance (vercel#…
98db695 
…27673)
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle approved these changes

@ijjk ijjk ijjk approved these changes

@huozhi huozhi Awaiting requested review from huozhi

@padmaia padmaia Awaiting requested review from padmaia

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sokra @ijjk @styfle