Skip to content

chore: update tsconfig-paths-webpack-plugin to 3.5.2 #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 17, 2022
Merged

chore: update tsconfig-paths-webpack-plugin to 3.5.2 #987

merged 2 commits into from
Oct 17, 2022

Conversation

fiws
Copy link
Contributor

@fiws fiws commented Oct 13, 2022 •
edited
Loading

This fixes a super annoying bug that can occur when baseUrl is set to . in the tsconfig.json. With the previous version of tsconfig-paths-webpack-plugin this would result in packages like mongoose not properly require-ing their own package.json but instead reading the package json of the root project.

also see jonaskello/tsconfig-paths-webpack-plugin@2d838a0

@fiws fiws requested review from styfle and Timer as code owners October 13, 2022 16:40
@fiws fiws force-pushed the update-tsconfig-paths-webpack-plugin branch 2 times, most recently from 8c20d31 to c294380 Compare October 13, 2022 16:42
@fiws fiws force-pushed the update-tsconfig-paths-webpack-plugin branch from c294380 to 08d7501 Compare October 13, 2022 16:42
styfle
styfle approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@styfle styfle added automerge Automatically merge PR once checks pass hacktoberfest-accepted labels Oct 13, 2022
@styfle styfle enabled auto-merge (squash) October 13, 2022 22:16
@fiws
Copy link
Contributor Author

fiws commented Oct 17, 2022

flaky tests?

@styfle styfle merged commit 3eba6a2 into vercel:main Oct 17, 2022
@fiws fiws mentioned this pull request Nov 2, 2022
Closed
@github-actions
Copy link

github-actions bot commented Dec 5, 2022

🎉 This PR is included in version 0.36.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle approved these changes

@Timer Timer Awaiting requested review from Timer Timer is a code owner

+1 more reviewer

@hebertcisco hebertcisco hebertcisco approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
automerge Automatically merge PR once checks pass hacktoberfest-accepted released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fiws @styfle @hebertcisco