fix(vercel): exit dev command on error #13438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c401ae8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
chris-olszewski
commented
Jun 11, 2025
Comment on lines
+136
to
+137
| clearTimeout(timeout); | ||
| controller.abort(); |
There was a problem hiding this comment.
Always clean up oidc refresh even if dev server has an error
chris-olszewski
commented
Jun 11, 2025
| envValues[VERCEL_OIDC_TOKEN] = token; | ||
| await devServer.runDevCommand(true); | ||
| telemetry.trackOidcTokenRefresh(++refreshCount); | ||
| try { |
There was a problem hiding this comment.
Required to ensure an error from the dev server is surfaced to the user and not an AbortError
chris-olszewski
commented
Jun 11, 2025
trek
previously approved these changes
Jun 11, 2025
trek
approved these changes
Jun 11, 2025
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 13, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## vercel@43.1.0 ### Minor Changes - Add blob subcommand ([#13364](#13364)) These are the new API's: `vc blob store add mystore` - creates a new blob store, asks to connect store to project and suggests pulling the new env var `vc blob store rm store_mystoreid` - delete a blob store All of the following commands will try to read the `BLOB_READ_WRITE_TOKEN` from the next `.env.local` file: `vc blob put file.txt` - uploads the file from the path to the blob store `vc blob ls` - list blobs in the store `vc blob del path/ path2/` - delete blobs from the store `vc blob copy fromUrl toPathname` - copies a file within the store ### Patch Changes - Fix bug where `vercel dev` would not exit on error ([#13438](#13438)) ## @vercel/functions@2.2.0 ### Minor Changes - Introduce `getVercelOidcTokenSync` ([#13429](#13429)) ## @vercel/client@15.3.5 ### Patch Changes - Updated dependencies \[[`b5fed7cca786d93b7c88af275ce1dca5e5b59098`](b5fed7c)]: - @vercel/routing-utils@5.0.7 ## @vercel/fs-detectors@5.4.4 ### Patch Changes - Updated dependencies \[[`b5fed7cca786d93b7c88af275ce1dca5e5b59098`](b5fed7c)]: - @vercel/routing-utils@5.0.7 ## @vercel/routing-utils@5.0.7 ### Patch Changes - Fixed TS literal type inference for compatibility with json-schema-to-ts ([#13446](#13446)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
QuietCraftsmanship
pushed a commit
to QuietCraftsmanship/Vercel
that referenced
this pull request
Jul 6, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## vercel@43.1.0 ### Minor Changes - Add blob subcommand ([#13364](vercel/vercel#13364)) These are the new API's: `vc blob store add mystore` - creates a new blob store, asks to connect store to project and suggests pulling the new env var `vc blob store rm store_mystoreid` - delete a blob store All of the following commands will try to read the `BLOB_READ_WRITE_TOKEN` from the next `.env.local` file: `vc blob put file.txt` - uploads the file from the path to the blob store `vc blob ls` - list blobs in the store `vc blob del path/ path2/` - delete blobs from the store `vc blob copy fromUrl toPathname` - copies a file within the store ### Patch Changes - Fix bug where `vercel dev` would not exit on error ([#13438](vercel/vercel#13438)) ## @vercel/functions@2.2.0 ### Minor Changes - Introduce `getVercelOidcTokenSync` ([#13429](vercel/vercel#13429)) ## @vercel/client@15.3.5 ### Patch Changes - Updated dependencies \[[`7462ba8a07c07bb8ce426e13ad539b32b58c07ff`](vercel/vercel@7462ba8)]: - @vercel/routing-utils@5.0.7 ## @vercel/fs-detectors@5.4.4 ### Patch Changes - Updated dependencies \[[`7462ba8a07c07bb8ce426e13ad539b32b58c07ff`](vercel/vercel@7462ba8)]: - @vercel/routing-utils@5.0.7 ## @vercel/routing-utils@5.0.7 ### Patch Changes - Fixed TS literal type inference for compatibility with json-schema-to-ts ([#13446](vercel/vercel#13446)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reenable test disabled in #13436
According to
git bisect#13226 broke this behavior. Unsure of how the passed on CI/up until recently as it was definitely broken.It looks like the
AbortControllerprevented the process from exiting.