[cli] add telemetry for `vercel domains inspect` #12407

trek · 2024-10-28T19:56:10Z

No description provided.

changeset-bot · 2024-10-28T19:56:15Z

🦋 Changeset detected

Latest commit: 4b032a2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
vercel	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

trek · 2024-10-28T19:57:05Z

packages/cli/test/mocks/domains.ts

@@ -5,8 +5,8 @@ export function createDomain(k?: string) {
  return {
    suffix: chance().bool(),
    verified: chance().bool(),
-    nameservers: chance().string(),
-    intendedNameservers: chance().string(),
+    nameservers: [chance().string()],


Based on use (and name) I believe these are string[] not string

trek · 2024-10-28T19:57:31Z

packages/cli/test/unit/commands/domains/inspect.test.ts

+      });
+      client.setArgv('domains', 'inspect', domain.name);
+      let exitCodePromise = domains(client);
+      await expect(exitCodePromise).resolves.toEqual(null);


I suspect null isn't what we want, but this is indeed the return value.

.changeset/tiny-horses-cry.md

wrong changeset

kodiakhq · 2024-10-28T21:06:35Z

This PR currently has a merge conflict. Please resolve this and then re-add the ['pr: automerge'] label.

…rcel-domains-inspect

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## vercel@37.13.0 ### Minor Changes - Add telemetry for `vercel logs` ([#12386](#12386)) - Add telemetry for `vercel env pull` ([#12368](#12368)) - add telemetry for `vercel env rm` ([#12384](#12384)) - [cli] add subcommand tracking for `dns` group ([#12375](#12375)) - [cli] add telemetry for `vercel certs ls` ([#12383](#12383)) - [cli] add telemetry tracking to vercel inspect ([#12367](#12367)) - Add telemetry for `vercel certs remove` ([#12394](#12394)) - Add telemetry for `vercel integration list` ([#12404](#12404)) - add telemetry tracking to `env add` ([#12357](#12357)) - track standard environments in `vc env add` ([#12385](#12385)) - [cli] add telemetry for `vercel target ls` ([#12352](#12352)) - [cli] add telemetry tracking for `vercel domains ls` ([#12400](#12400)) - [cli] add `VERCEL_ENV` and `VERCEL` to process to simulate runtime ([#12358](#12358)) - Add telemetry for `vercel domains move` ([#12411](#12411)) - [cli] add telemetry tracking to `git connect` and `git disconnect` ([#12373](#12373)) - Add telemetry to `vercel domains buy` ([#12413](#12413)) - [cli] add telemetry tracking to `project list` ([#12339](#12339)) - Add telemetry for `vercel domains add` ([#12409](#12409)) - Add telemetry to `vercel domains rm` ([#12410](#12410)) - Add telemetry for `vercel list` ([#12364](#12364)) - [cli] add subcommand tracking for `integration` group ([#12377](#12377)) - Add telemetry for `vercel certs add` ([#12391](#12391)) - [cli] add subcommand tracking for `domains` group ([#12374](#12374)) - [cli] add telemetry tracking to `project add` ([#12340](#12340)) - Add telemetry for `vercel integration open` ([#12408](#12408)) - Add telemetry for `vercel init` ([#12371](#12371)) - [cli] add subcommand tracking for `integration` group ([#12377](#12377)) - [cli] add telemetry tracking for `vercel dns import` ([#12379](#12379)) - [cli] add telemetry for `vercel dns ls` ([#12380](#12380)) - Add telemetry for `vercel env ls` ([#12392](#12392)) - Add telemetry for `vercel bisect` ([#12362](#12362)) - [cli] add telemetry for `vercel dns remove` ([#12381](#12381)) - Add telemetry for `vercel integration add` ([#12406](#12406)) - [cli] add telemetry tracking for vercel dev invocations ([#12349](#12349)) - [cli] add subcommand tracking for `certs` group ([#12376](#12376)) - [cli] add telemetry for `vercel redeploy` ([#12353](#12353)) - [cli] add telemetry for `vercel domains inspect` ([#12407](#12407)) - Add telemetry for `vercel certs issue` ([#12401](#12401)) - Add telemetry for `vercel link` ([#12360](#12360)) ### Patch Changes - Remove stray file ([#12363](#12363)) - add metrics to dns add ([#12414](#12414)) - Add telemetry to the `teams` subcommands. Telemetry collection is not currently enabled and when it is, will be a major version bump for the CLI. ([#12346](#12346)) - add telemetry to `vc pull` ([#12387](#12387)) - [cli] refactor Output usage ([#12305](#12305)) - extract pull invocation from build ([#12372](#12372)) - extract vc pull logic from entrypoint ([#12378](#12378)) - Updated dependencies \[[`13bb443f2b0791c7bd402447fcb540cffd0b6eae`](13bb443)]: - @vercel/remix-builder@2.2.13 ## @vercel/remix-builder@2.2.13 ### Patch Changes - Update `@remix-run/dev` fork to v2.13.1 ([#12334](#12334)) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## vercel@37.13.0 ### Minor Changes - Add telemetry for `vercel logs` ([#12386](vercel/vercel#12386)) - Add telemetry for `vercel env pull` ([#12368](vercel/vercel#12368)) - add telemetry for `vercel env rm` ([#12384](vercel/vercel#12384)) - [cli] add subcommand tracking for `dns` group ([#12375](vercel/vercel#12375)) - [cli] add telemetry for `vercel certs ls` ([#12383](vercel/vercel#12383)) - [cli] add telemetry tracking to vercel inspect ([#12367](vercel/vercel#12367)) - Add telemetry for `vercel certs remove` ([#12394](vercel/vercel#12394)) - Add telemetry for `vercel integration list` ([#12404](vercel/vercel#12404)) - add telemetry tracking to `env add` ([#12357](vercel/vercel#12357)) - track standard environments in `vc env add` ([#12385](vercel/vercel#12385)) - [cli] add telemetry for `vercel target ls` ([#12352](vercel/vercel#12352)) - [cli] add telemetry tracking for `vercel domains ls` ([#12400](vercel/vercel#12400)) - [cli] add `VERCEL_ENV` and `VERCEL` to process to simulate runtime ([#12358](vercel/vercel#12358)) - Add telemetry for `vercel domains move` ([#12411](vercel/vercel#12411)) - [cli] add telemetry tracking to `git connect` and `git disconnect` ([#12373](vercel/vercel#12373)) - Add telemetry to `vercel domains buy` ([#12413](vercel/vercel#12413)) - [cli] add telemetry tracking to `project list` ([#12339](vercel/vercel#12339)) - Add telemetry for `vercel domains add` ([#12409](vercel/vercel#12409)) - Add telemetry to `vercel domains rm` ([#12410](vercel/vercel#12410)) - Add telemetry for `vercel list` ([#12364](vercel/vercel#12364)) - [cli] add subcommand tracking for `integration` group ([#12377](vercel/vercel#12377)) - Add telemetry for `vercel certs add` ([#12391](vercel/vercel#12391)) - [cli] add subcommand tracking for `domains` group ([#12374](vercel/vercel#12374)) - [cli] add telemetry tracking to `project add` ([#12340](vercel/vercel#12340)) - Add telemetry for `vercel integration open` ([#12408](vercel/vercel#12408)) - Add telemetry for `vercel init` ([#12371](vercel/vercel#12371)) - [cli] add subcommand tracking for `integration` group ([#12377](vercel/vercel#12377)) - [cli] add telemetry tracking for `vercel dns import` ([#12379](vercel/vercel#12379)) - [cli] add telemetry for `vercel dns ls` ([#12380](vercel/vercel#12380)) - Add telemetry for `vercel env ls` ([#12392](vercel/vercel#12392)) - Add telemetry for `vercel bisect` ([#12362](vercel/vercel#12362)) - [cli] add telemetry for `vercel dns remove` ([#12381](vercel/vercel#12381)) - Add telemetry for `vercel integration add` ([#12406](vercel/vercel#12406)) - [cli] add telemetry tracking for vercel dev invocations ([#12349](vercel/vercel#12349)) - [cli] add subcommand tracking for `certs` group ([#12376](vercel/vercel#12376)) - [cli] add telemetry for `vercel redeploy` ([#12353](vercel/vercel#12353)) - [cli] add telemetry for `vercel domains inspect` ([#12407](vercel/vercel#12407)) - Add telemetry for `vercel certs issue` ([#12401](vercel/vercel#12401)) - Add telemetry for `vercel link` ([#12360](vercel/vercel#12360)) ### Patch Changes - Remove stray file ([#12363](vercel/vercel#12363)) - add metrics to dns add ([#12414](vercel/vercel#12414)) - Add telemetry to the `teams` subcommands. Telemetry collection is not currently enabled and when it is, will be a major version bump for the CLI. ([#12346](vercel/vercel#12346)) - add telemetry to `vc pull` ([#12387](vercel/vercel#12387)) - [cli] refactor Output usage ([#12305](vercel/vercel#12305)) - extract pull invocation from build ([#12372](vercel/vercel#12372)) - extract vc pull logic from entrypoint ([#12378](vercel/vercel#12378)) - Updated dependencies \[[`e4304c4526f6062d23b7fdb381d9bb24c7431a0d`](vercel/vercel@e4304c4)]: - @vercel/remix-builder@2.2.13 ## @vercel/remix-builder@2.2.13 ### Patch Changes - Update `@remix-run/dev` fork to v2.13.1 ([#12334](vercel/vercel#12334)) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

[cli] add telemetry for vercel domains ls

63f1b97

Create tiny-horses-cry.md

ba112e3

trek commented Oct 28, 2024

View reviewed changes

vercel bot deployed to Preview October 28, 2024 19:57 View deployment

trek commented Oct 28, 2024

View reviewed changes

trek marked this pull request as ready for review October 28, 2024 20:13

trek requested review from TooTallNate, EndangeredMassa, onsclom, jeffsee55 and erikareads as code owners October 28, 2024 20:13

erikareads previously approved these changes Oct 28, 2024

View reviewed changes

.changeset/tiny-horses-cry.md Outdated Show resolved Hide resolved

trek changed the title ~~[cli] add telemetry for vercel domains ls~~ [cli] add telemetry for vercel domains inspect Oct 28, 2024

Update tiny-horses-cry.md

8b959ea

trek requested a review from erikareads October 28, 2024 20:19

vercel bot deployed to Preview October 28, 2024 20:20 View deployment

EndangeredMassa previously approved these changes Oct 28, 2024

View reviewed changes

trek added the pr: automerge Automatically merge the PR when checks pass label Oct 28, 2024

erikareads previously approved these changes Oct 28, 2024

View reviewed changes

kodiakhq bot removed the pr: automerge Automatically merge the PR when checks pass label Oct 28, 2024

Merge branch 'main' into trek/zero-2663-add-telemetry-tracking-for-ve…

239cae9

…rcel-domains-inspect

EndangeredMassa dismissed stale reviews from erikareads and themself via 239cae9 October 28, 2024 21:09

EndangeredMassa approved these changes Oct 28, 2024

View reviewed changes

vercel bot deployed to Preview October 28, 2024 21:12 View deployment

Merge branch 'main' into trek/zero-2663-add-telemetry-tracking-for-ve…

7b5d53c

…rcel-domains-inspect

vercel bot deployed to Preview October 29, 2024 12:48 View deployment

Merge branch 'main' into trek/zero-2663-add-telemetry-tracking-for-ve…

4b032a2

…rcel-domains-inspect

vercel bot deployed to Preview October 29, 2024 14:11 View deployment

trek merged commit e2e963a into main Oct 29, 2024
138 checks passed

trek deleted the trek/zero-2663-add-telemetry-tracking-for-vercel-domains-inspect branch October 29, 2024 14:48

vercel-release-bot mentioned this pull request Oct 29, 2024

Version Packages #12345

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[cli] add telemetry for `vercel domains inspect` #12407

[cli] add telemetry for `vercel domains inspect` #12407

Uh oh!

trek commented Oct 28, 2024

Uh oh!

changeset-bot bot commented Oct 28, 2024 •

edited

Loading

Uh oh!

trek Oct 28, 2024

Uh oh!

trek Oct 28, 2024

Uh oh!

Uh oh!

kodiakhq bot commented Oct 28, 2024

Uh oh!

Uh oh!

Uh oh!

[cli] add telemetry for vercel domains inspect #12407

[cli] add telemetry for vercel domains inspect #12407

Uh oh!

Conversation

trek commented Oct 28, 2024

Uh oh!

changeset-bot bot commented Oct 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

trek Oct 28, 2024

Choose a reason for hiding this comment

Uh oh!

trek Oct 28, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kodiakhq bot commented Oct 28, 2024

Uh oh!

Uh oh!

Uh oh!

[cli] add telemetry for `vercel domains inspect` #12407

[cli] add telemetry for `vercel domains inspect` #12407

changeset-bot bot commented Oct 28, 2024 •

edited

Loading