Skip to content

extract vc pull logic from entrypoint #12378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 25, 2024
Merged

Conversation

EndangeredMassa
Copy link
Contributor

@EndangeredMassa EndangeredMassa commented Oct 25, 2024

This is a very basic extraction of the core vc pull logic out of the command invocation for use in the build command invocation. This gives us a place to add telemetry later in only the vc pull invocation logic so that invoking vc build does not trigger vc pull telemetry metrics.

I manually tested this to make sure I didn't break it.

Copy link

changeset-bot bot commented Oct 25, 2024

🦋 Changeset detected

Latest commit: f7fcfce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -25,12 +26,12 @@ async function pullAllEnvFiles(
environment: string,
client: Client,
link: ProjectLinked,
flags: PullCommandFlags,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the wrong type before, but the types happened to be compatible.

@EndangeredMassa EndangeredMassa added the pr: automerge Automatically merge the PR when checks pass label Oct 25, 2024
@kodiakhq kodiakhq bot merged commit ea89033 into main Oct 25, 2024
138 checks passed
@kodiakhq kodiakhq bot deleted the smassa/extract-vc-pull-logic branch October 25, 2024 18:16
onsclom pushed a commit that referenced this pull request Oct 29, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## vercel@37.13.0

### Minor Changes

- Add telemetry for `vercel logs`
([#12386](#12386))

- Add telemetry for `vercel env pull`
([#12368](#12368))

- add telemetry for `vercel env rm`
([#12384](#12384))

- [cli] add subcommand tracking for `dns` group
([#12375](#12375))

- [cli] add telemetry for `vercel certs ls`
([#12383](#12383))

- [cli] add telemetry tracking to vercel inspect
([#12367](#12367))

- Add telemetry for `vercel certs remove`
([#12394](#12394))

- Add telemetry for `vercel integration list`
([#12404](#12404))

- add telemetry tracking to `env add`
([#12357](#12357))

- track standard environments in `vc env add`
([#12385](#12385))

- [cli] add telemetry for `vercel target ls`
([#12352](#12352))

- [cli] add telemetry tracking for `vercel domains ls`
([#12400](#12400))

- [cli] add `VERCEL_ENV` and `VERCEL` to process to simulate runtime
([#12358](#12358))

- Add telemetry for `vercel domains move`
([#12411](#12411))

- [cli] add telemetry tracking to `git connect` and `git disconnect`
([#12373](#12373))

- Add telemetry to `vercel domains buy`
([#12413](#12413))

- [cli] add telemetry tracking to `project list`
([#12339](#12339))

- Add telemetry for `vercel domains add`
([#12409](#12409))

- Add telemetry to `vercel domains rm`
([#12410](#12410))

- Add telemetry for `vercel list`
([#12364](#12364))

- [cli] add subcommand tracking for `integration` group
([#12377](#12377))

- Add telemetry for `vercel certs add`
([#12391](#12391))

- [cli] add subcommand tracking for `domains` group
([#12374](#12374))

- [cli] add telemetry tracking to `project add`
([#12340](#12340))

- Add telemetry for `vercel integration open`
([#12408](#12408))

- Add telemetry for `vercel init`
([#12371](#12371))

- [cli] add subcommand tracking for `integration` group
([#12377](#12377))

- [cli] add telemetry tracking for `vercel dns import`
([#12379](#12379))

- [cli] add telemetry for `vercel dns ls`
([#12380](#12380))

- Add telemetry for `vercel env ls`
([#12392](#12392))

- Add telemetry for `vercel bisect`
([#12362](#12362))

- [cli] add telemetry for `vercel dns remove`
([#12381](#12381))

- Add telemetry for `vercel integration add`
([#12406](#12406))

- [cli] add telemetry tracking for vercel dev invocations
([#12349](#12349))

- [cli] add subcommand tracking for `certs` group
([#12376](#12376))

- [cli] add telemetry for `vercel redeploy`
([#12353](#12353))

- [cli] add telemetry for `vercel domains inspect`
([#12407](#12407))

- Add telemetry for `vercel certs issue`
([#12401](#12401))

- Add telemetry for `vercel link`
([#12360](#12360))

### Patch Changes

- Remove stray file
([#12363](#12363))

- add metrics to dns add
([#12414](#12414))

- Add telemetry to the `teams` subcommands. Telemetry collection is not
currently enabled and when it is, will be a major version bump for the
CLI. ([#12346](#12346))

- add telemetry to `vc pull`
([#12387](#12387))

- [cli] refactor Output usage
([#12305](#12305))

- extract pull invocation from build
([#12372](#12372))

- extract vc pull logic from entrypoint
([#12378](#12378))

- Updated dependencies
\[[`13bb443f2b0791c7bd402447fcb540cffd0b6eae`](13bb443)]:
    -   @vercel/remix-builder@2.2.13

## @vercel/remix-builder@2.2.13

### Patch Changes

- Update `@remix-run/dev` fork to v2.13.1
([#12334](#12334))

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
QuietCraftsmanship added a commit to QuietCraftsmanship/Vercel that referenced this pull request Jul 6, 2025
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## vercel@37.13.0

### Minor Changes

- Add telemetry for `vercel logs`
([#12386](vercel/vercel#12386))

- Add telemetry for `vercel env pull`
([#12368](vercel/vercel#12368))

- add telemetry for `vercel env rm`
([#12384](vercel/vercel#12384))

- [cli] add subcommand tracking for `dns` group
([#12375](vercel/vercel#12375))

- [cli] add telemetry for `vercel certs ls`
([#12383](vercel/vercel#12383))

- [cli] add telemetry tracking to vercel inspect
([#12367](vercel/vercel#12367))

- Add telemetry for `vercel certs remove`
([#12394](vercel/vercel#12394))

- Add telemetry for `vercel integration list`
([#12404](vercel/vercel#12404))

- add telemetry tracking to `env add`
([#12357](vercel/vercel#12357))

- track standard environments in `vc env add`
([#12385](vercel/vercel#12385))

- [cli] add telemetry for `vercel target ls`
([#12352](vercel/vercel#12352))

- [cli] add telemetry tracking for `vercel domains ls`
([#12400](vercel/vercel#12400))

- [cli] add `VERCEL_ENV` and `VERCEL` to process to simulate runtime
([#12358](vercel/vercel#12358))

- Add telemetry for `vercel domains move`
([#12411](vercel/vercel#12411))

- [cli] add telemetry tracking to `git connect` and `git disconnect`
([#12373](vercel/vercel#12373))

- Add telemetry to `vercel domains buy`
([#12413](vercel/vercel#12413))

- [cli] add telemetry tracking to `project list`
([#12339](vercel/vercel#12339))

- Add telemetry for `vercel domains add`
([#12409](vercel/vercel#12409))

- Add telemetry to `vercel domains rm`
([#12410](vercel/vercel#12410))

- Add telemetry for `vercel list`
([#12364](vercel/vercel#12364))

- [cli] add subcommand tracking for `integration` group
([#12377](vercel/vercel#12377))

- Add telemetry for `vercel certs add`
([#12391](vercel/vercel#12391))

- [cli] add subcommand tracking for `domains` group
([#12374](vercel/vercel#12374))

- [cli] add telemetry tracking to `project add`
([#12340](vercel/vercel#12340))

- Add telemetry for `vercel integration open`
([#12408](vercel/vercel#12408))

- Add telemetry for `vercel init`
([#12371](vercel/vercel#12371))

- [cli] add subcommand tracking for `integration` group
([#12377](vercel/vercel#12377))

- [cli] add telemetry tracking for `vercel dns import`
([#12379](vercel/vercel#12379))

- [cli] add telemetry for `vercel dns ls`
([#12380](vercel/vercel#12380))

- Add telemetry for `vercel env ls`
([#12392](vercel/vercel#12392))

- Add telemetry for `vercel bisect`
([#12362](vercel/vercel#12362))

- [cli] add telemetry for `vercel dns remove`
([#12381](vercel/vercel#12381))

- Add telemetry for `vercel integration add`
([#12406](vercel/vercel#12406))

- [cli] add telemetry tracking for vercel dev invocations
([#12349](vercel/vercel#12349))

- [cli] add subcommand tracking for `certs` group
([#12376](vercel/vercel#12376))

- [cli] add telemetry for `vercel redeploy`
([#12353](vercel/vercel#12353))

- [cli] add telemetry for `vercel domains inspect`
([#12407](vercel/vercel#12407))

- Add telemetry for `vercel certs issue`
([#12401](vercel/vercel#12401))

- Add telemetry for `vercel link`
([#12360](vercel/vercel#12360))

### Patch Changes

- Remove stray file
([#12363](vercel/vercel#12363))

- add metrics to dns add
([#12414](vercel/vercel#12414))

- Add telemetry to the `teams` subcommands. Telemetry collection is not
currently enabled and when it is, will be a major version bump for the
CLI. ([#12346](vercel/vercel#12346))

- add telemetry to `vc pull`
([#12387](vercel/vercel#12387))

- [cli] refactor Output usage
([#12305](vercel/vercel#12305))

- extract pull invocation from build
([#12372](vercel/vercel#12372))

- extract vc pull logic from entrypoint
([#12378](vercel/vercel#12378))

- Updated dependencies
\[[`e4304c4526f6062d23b7fdb381d9bb24c7431a0d`](vercel/vercel@e4304c4)]:
    -   @vercel/remix-builder@2.2.13

## @vercel/remix-builder@2.2.13

### Patch Changes

- Update `@remix-run/dev` fork to v2.13.1
([#12334](vercel/vercel#12334))

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: automerge Automatically merge the PR when checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants