Avoid retries by default when using the MockClient #12354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 001bc9f The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
trek
previously approved these changes
Oct 23, 2024
…est-mock-500-responses-not
trek
reviewed
Oct 23, 2024
| @@ -183,7 +183,7 @@ describe('rollback', () => { | |||
| `Fetching deployment "${previousDeployment.id}" in ${previousDeployment.creator?.username}` | |||
| ); | |||
| // we need to wait a super long time because fetch will return on 500 | |||
There was a problem hiding this comment.
I think we can remove this comment now too. It wasn't even terribly accurate.
jeffsee55
commented
Oct 23, 2024
EndangeredMassa
approved these changes
Oct 23, 2024
…est-mock-500-responses-not
trek
pushed a commit
that referenced
this pull request
Oct 24, 2024
When some of our test mocks intentionally respond with a 500, that response takes several seconds because the [client's `fetch` function](https://github.com/vercel/vercel/blob/7e8fbd20e01135513ad28936155b078650732d37/packages/cli/src/util/client.ts#L173-L174) automatically retries the request. But since we're mocking these requests we should just automatically fail.
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 29, 2024
For those of us who use a debugger, the test suit exiting early is frustrating. You can get around this by setting this value yourself or running with `--testTimeout` in the terminal but adding this behavior globally seems like a nice quality of life change.
I couldn't find a 100% guaranteed way to detect if node is in debug mode but the rough consensus was detecting `debugPort` covered the largest number of cases.
I audited all the uses of `vi.setConfig({ testTimeout });` in `packages/cli` and only found one that looked like it could definitely be removed. The use case it covered was negated by #12354.
The others mostly came from 413706d or had a comment explaining their need.
QuietCraftsmanship
pushed a commit
to QuietCraftsmanship/Vercel
that referenced
this pull request
Jul 6, 2025
For those of us who use a debugger, the test suit exiting early is frustrating. You can get around this by setting this value yourself or running with `--testTimeout` in the terminal but adding this behavior globally seems like a nice quality of life change.
I couldn't find a 100% guaranteed way to detect if node is in debug mode but the rough consensus was detecting `debugPort` covered the largest number of cases.
I audited all the uses of `vi.setConfig({ testTimeout });` in `packages/cli` and only found one that looked like it could definitely be removed. The use case it covered was negated by vercel/vercel#12354.
The others mostly came from vercel/vercel@fa07756 or had a comment explaining their need.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When some of our test mocks intentionally respond with a 500, that response takes several seconds because the client's
fetchfunction automatically retries the request.But since we're mocking these requests we should just automatically fail.