Skip to content

Conversation

mehulkar
Copy link
Contributor

@mehulkar mehulkar commented Feb 11, 2023

Only allow the error where workspace config is missing, since
this config is not required. Throw other errors, including
when the contents of the workspace config are malformed.
This allows us to provide better error messaging to the end user

@vercel
Copy link
Contributor

vercel bot commented Feb 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
examples-native-web 🔄 Building (Inspect) Feb 11, 2023 at 7:17PM (UTC)
examples-nonmonorepo 🔄 Building (Inspect) Feb 11, 2023 at 7:17PM (UTC)
8 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Feb 11, 2023 at 7:17PM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Feb 11, 2023 at 7:17PM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Feb 11, 2023 at 7:17PM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Feb 11, 2023 at 7:17PM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Feb 11, 2023 at 7:17PM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Feb 11, 2023 at 7:17PM (UTC)
examples-vite-web ⬜️ Ignored (Inspect) Feb 11, 2023 at 7:17PM (UTC)
turbo-site ⬜️ Ignored (Inspect) Visit Preview Feb 11, 2023 at 7:17PM (UTC)

@mehulkar mehulkar changed the title Mehulkar/turbo 779 better error messaging for bad contents improve error messaging on bad turbo.json contents Feb 11, 2023
@mehulkar mehulkar force-pushed the mehulkar/turbo-779-better-error-messaging-for-bad-contents branch from 9fa6356 to e3caf0a Compare February 11, 2023 17:03
@mehulkar mehulkar changed the title improve error messaging on bad turbo.json contents Improve error bubbling Feb 11, 2023
@mehulkar mehulkar mentioned this pull request Feb 11, 2023
5 tasks
@mehulkar mehulkar force-pushed the mehulkar/turbo-779-better-error-messaging-for-bad-contents branch from 82ae100 to f5cce75 Compare February 11, 2023 17:30
@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2023

🟢 CI successful 🟢

Thanks

Only allow the error where workspace config is missing, since
this config is not required. Throw other errors, including
when the contents of the workspace config are malformed.
@mehulkar mehulkar force-pushed the mehulkar/turbo-779-better-error-messaging-for-bad-contents branch from 0ca7db5 to e5eb7ac Compare February 11, 2023 19:16
@mehulkar mehulkar marked this pull request as ready for review February 11, 2023 20:06
@mehulkar mehulkar requested a review from a team as a code owner February 11, 2023 20:06
@mehulkar mehulkar requested review from nathanhammond, NicholasLYang, gsoltis and chris-olszewski and removed request for a team February 11, 2023 20:06
@mehulkar mehulkar merged commit ef32cf3 into mehulkar/turbo-538-composable-turbojson Feb 11, 2023
@mehulkar mehulkar deleted the mehulkar/turbo-779-better-error-messaging-for-bad-contents branch February 11, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant