-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Allow overriding persistent flag from workspace #3730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow overriding persistent flag from workspace #3730
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
@@ -118,6 +118,12 @@ func (e *Engine) getTaskDefinition(pkg string, taskName string, taskID string) ( | |||
}, nil | |||
} | |||
|
|||
// An error here means turbo.json exists, but didn't define the task. | |||
// Fallback to the root pipeline to find the task. | |||
if pkg != util.RootPkgName { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this condition wasn't exercised by any of the other tests yet... something about #3729 caused this change, because the refactor returned empty structs in some cases rather than throwing errors.
Socket Security Pull Request ReportDependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again. 📜 Install scriptsInstall scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts. Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.
Pull request report summary
Bot CommandsTo ignore an alert, reply with a comment starting with
Powered by socket.dev |
🟢 CI successful 🟢Thanks |
Will do
cache
key next