Move persistent deps tests to prysk #3566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 10 Ignored Deployments
|
🟢 CI successful 🟢Thanks |
These tests make heavy use of the internals of setting up a TaskGraph. We want to rework how that happens to support lazily loading task definitions. Instead of rewriting all these unit tests, this commit updates the tests to integration tests, so we don't have to worry about the internals. This will also make the tests resilient to the Rust port.
ca327b1 to
f973300
Compare
chris-olszewski
approved these changes
Feb 1, 2023
Comment on lines
+1
to
+15
| # Setup | ||
| $ . ${TESTDIR}/../setup.sh | ||
| $ . ${TESTDIR}/setup.sh $(pwd) 1-topological | ||
|
|
||
| // Workspace Graph | ||
| // - app-a depends on pkg-a | ||
| // | ||
| // Make this Task Graph: | ||
| // dev | ||
| // └── ^dev | ||
| // | ||
| // With this workspace graph, that means: | ||
| // | ||
| // app-a#dev | ||
| // └── pkg-a#dev |
There was a problem hiding this comment.
Not that it's blocking, but is there a reason for the leading # and // used for the comments in the cram file? IMO it adds a fair bit of noise.
There was a problem hiding this comment.
Not really. I guess it helps if you don't have syntax highlighting for the files, but I think it was mostly just a habit thing from me.
The discrepancy of # and // is because I was copy pasting comments from Go and I guess I didn't make all of them consistent.
This was referenced Feb 2, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests make heavy use of the internals of setting up a TaskGraph. In #3562, this is changing significantly. Instead of rewriting unit tests here that again touch the internals, I'm updating these tests to integration tests. This also means that we can continue using these as validation as we move to Rust.
I considered writing these tests with tasks in all one monorepo, but it ends up being a lot more confusing to read the tests that way, and I didn't want to spend that much time on this. There may be a future in which it's useful to generate monorepos with conditions to reduce the amount of boilerplate.