Refactor Task Definition retrieval to support composable configs #3405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This moves TopoDeps generation a bit later, when we're iterating tasks per workspace. The advantage of this is that we will be able to calculate topological dependencies per-workspace, so that composable configs can play a role in this.
🟢 CI successful 🟢Thanks |
gsoltis
approved these changes
Jan 20, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to create composable configs, we need to calculate Task dependencies and topological dependencies when iterating per-workspace. Currently this happens too early.
This PR moves just topological dependencies, because there is no business logic around them. In a future PR, I will also move task dependencies over once. This refactor should not affect that.
Reviewing commits one at a time will probably be best here.