Factor out ReadTurboConfig method #3368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Ignored Deployments
|
🟢 CI successful 🟢Thanks |
We need this method to be able to read arbitrary turbo.json files and not fallback on package.json config or synthesizing one from the package.json
b1254ba to
73736ea
Compare
chris-olszewski
approved these changes
Jan 18, 2023
| // If there's no turbo.json and no turbo key in package.json, return an error. | ||
| return nil, errors.Wrapf(os.ErrNotExist, "Could not find %s. Follow directions at https://turbo.build/repo/docs to create one", configFile) | ||
| // If there's no turbo.json, return an error. | ||
| return nil, errors.Wrapf(os.ErrNotExist, "Could not find %s", configFile) |
There was a problem hiding this comment.
Was there a reason to drop the link to the docs? It's causing the unit tests to fail.
There was a problem hiding this comment.
The goal was to make it more general purpose since this method will be used for turbo.json's other than the root one. But let me double check we didn't lose the error message for the existing use case.
There was a problem hiding this comment.
Great catch, it's back now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need this method to be able to read arbitrary turbo.json files and not fallback on package.json config or synthesizing one from the package.json.
Some work extracted from #2706.