Skip to content

Wire up api and team flags with viper #2053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2022
Merged

Wire up api and team flags with viper #2053

merged 1 commit into from
Sep 22, 2022

Conversation

gsoltis
Copy link
Contributor

@gsoltis gsoltis commented Sep 22, 2022

  • Ensure we are binding --api and --team to viper.
  • Ensure we don't mix a config-produced teamId with a flag-produced teamSlug
  • Add a test for the desired behavior

Fixes #2040

@gsoltis gsoltis requested a review from a team as a code owner September 22, 2022 22:27
@vercel
Copy link
Contributor

vercel bot commented Sep 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
turbo-site ✅ Ready (Inspect) Visit Preview Sep 22, 2022 at 10:27PM (UTC)

@gsoltis gsoltis added the pr: automerge Kodiak will merge these automatically after checks pass label Sep 22, 2022
@kodiakhq kodiakhq bot merged commit 2539ef1 into main Sep 22, 2022
@kodiakhq kodiakhq bot deleted the gsoltis/fix_api_team_flags branch September 22, 2022 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tknickman tknickman Awaiting requested review from tknickman tknickman is a code owner automatically assigned from vercel/turbo-oss

1 more reviewer

@chris-olszewski chris-olszewski chris-olszewski approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--api and --team CLI options are ignored for turbo run
2 participants
@gsoltis @chris-olszewski