Skip to content

Ensure environment variables are sorted #2054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 23, 2022
Merged

Ensure environment variables are sorted #2054

merged 2 commits into from
Sep 23, 2022

Conversation

gsoltis
Copy link
Contributor

@gsoltis gsoltis commented Sep 22, 2022 •
edited
Loading

Unsorted environment variables cause hashes to be unstable, meaning a large number of environment variables leads to essentially no cache hits.

Fixes #2029

@gsoltis gsoltis requested a review from a team as a code owner September 22, 2022 23:30
@vercel
Copy link
Contributor

vercel bot commented Sep 22, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
turbo-site ⬜️ Ignored (Inspect) Visit Preview Sep 23, 2022 at 2:55AM (UTC)

This was referenced Sep 22, 2022
Closed
Closed
gaspar09
gaspar09 approved these changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@gaspar09 gaspar09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤯

@gsoltis gsoltis added the pr: automerge Kodiak will merge these automatically after checks pass label Sep 23, 2022
@kodiakhq kodiakhq bot merged commit e824725 into main Sep 23, 2022
@kodiakhq kodiakhq bot deleted the gsoltis/fix_global_hash branch September 23, 2022 03:06
@mehulkar mehulkar mentioned this pull request Sep 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaspar09 gaspar09 gaspar09 approved these changes

@jaredpalmer jaredpalmer Awaiting requested review from jaredpalmer jaredpalmer is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Always getting "cache miss" in a simple lint task
2 participants
@gsoltis @gaspar09