Skip to content

Combine AbsolutePath and AbsoluteSystemPath #2026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Sep 22, 2022
Merged

Combine AbsolutePath and AbsoluteSystemPath #2026

merged 15 commits into from
Sep 22, 2022

Conversation

nathanhammond
Copy link
Contributor

@nathanhammond nathanhammond commented Sep 21, 2022 •
edited
Loading

AbsolutePath and AbsoluteSystemPath were representing the same thing. Now they're merged.

Four commits, each mechanical:

  • AbsolutePath.Join => AbsolutePath.UnsafeJoin
  • Dump contents of absolute_path.go into absolute_system_path.go
  • Merging of the types.
  • Removal of asString, no need for an internal/external distinction for string(p). (Now calls ToString internally.)

Followups:

  • Update places where renaming symbols failed.
  • Rename to UntypedJoin
  • Removed the utility functions originally extracted and inlined them. Add comments to make linter happy.
  • Removed the log from EnsureDir. We shouldn't have this.

@nathanhammond nathanhammond requested a review from a team as a code owner September 21, 2022 04:57
@vercel
Copy link
Contributor

vercel bot commented Sep 21, 2022

@nathanhammond is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link
Contributor

vercel bot commented Sep 21, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
turbo-site ✅ Ready (Inspect) Visit Preview Sep 22, 2022 at 7:51PM (UTC)

@nathanhammond nathanhammond mentioned this pull request Sep 21, 2022
Merged
@nathanhammond nathanhammond added the pr: automerge Kodiak will merge these automatically after checks pass label Sep 22, 2022
@gsoltis gsoltis merged commit ff76083 into vercel:main Sep 22, 2022
@nathanhammond nathanhammond deleted the collapse-absolute-path branch September 23, 2022 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaspar09 gaspar09 Awaiting requested review from gaspar09 gaspar09 is a code owner automatically assigned from vercel/turbo-oss

1 more reviewer

@gsoltis gsoltis gsoltis approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nathanhammond @gsoltis