-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feature: enhance dry-run with cache status #1988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@sppatel is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this!
I have a few hopefully-minor cosmetic requests, and one feature request.
Looking forward to getting this merged!
Appreciate the quick feed back - will address the review comments. |
Ok - I think I addressed the current set of review comments. One thing I realized was that this "may" require remote cache implementations to support HEAD requests to take advantage of this feature. |
@gsoltis I also locally implemented HEAD support for https://github.com/ducktors/turborepo-remote-cache - in order to verify functionality. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good. I think a couple minor details then let's get this merged!
@sppatel I think the linter issue is real, the other test failure looks unrelated. |
How can I rerun to verify the lint fixes? Locally i also received this error on the naming of CacheState
I went with the recommended name of "State" - but if you'd want something different/more explicit - happy to change it. |
re: |
Mind re-kicking the status checks again when u get a moment to see if we're good now? |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Test failure is unrelated. Force-merging. |
@sppatel I know this is something people have been asking for, thanks for diving in on it! |
Absolutely! Appreciate all the help and feedback! |
This PR attempts to resolve #1437. Dry run is extended to include a cache state. During dry run execution we reach out to the cache via a HEAD request to verify the cache entry at the location represented by the cache. Note that this may require adoption from remote service implementations to support (e.g implementing a HEAD route).
Would appreciate any feedback/advice.