-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
docs(dashboard): Updating inline docblocks #3714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Caution Review failedThe pull request is closed. WalkthroughDocumentation comments were added or enhanced across multiple dashboard extension API TypeScript interfaces, clarifying the purpose and usage of properties and interfaces related to login extensions, custom form components, detail forms, data tables, navigation, layout, widgets, and dashboard extensions. No code or type signatures were changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/dashboard/src/lib/framework/extension-api/types/login.ts
(5 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
packages/dashboard/src/**/*.{ts,tsx}
📄 CodeRabbit Inference Engine (.cursor/rules/dashboard.mdc)
packages/dashboard/src/**/*.{ts,tsx}
: Use TanStack Query (useQuery or useMutation) for data fetching; do not use Apollo Client.
When creating useQuery calls, follow the provided pattern: import { api } from '@/graphql/api.js'; import { graphql } from '@/graphql/graphql.js'; use useQuery with queryKey, staleTime, and queryFn using api.query.
When performing mutations, follow the provided useMutation pattern: use graphql() for the mutation document, api.mutate for mutationFn, and do not pass variables at declaration.
Files:
packages/dashboard/src/lib/framework/extension-api/types/login.ts
packages/dashboard/src/**/*.{tsx,ts}
📄 CodeRabbit Inference Engine (.cursor/rules/dashboard.mdc)
React component props objects should be typed as Readonly<...>.
Files:
packages/dashboard/src/lib/framework/extension-api/types/login.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)
- GitHub Check: e2e tests (22.x, postgres)
- GitHub Check: codegen / codegen
- GitHub Check: build (20.x)
- GitHub Check: build (24.x)
- GitHub Check: build (22.x)
- GitHub Check: unit tests (22.x)
- GitHub Check: publish_install (windows-latest, 24.x)
- GitHub Check: publish_install (windows-latest, 22.x)
- GitHub Check: publish_install (ubuntu-latest, 22.x)
- GitHub Check: publish_install (ubuntu-latest, 24.x)
- GitHub Check: publish_install (macos-latest, 24.x)
- GitHub Check: publish_install (macos-latest, 20.x)
- GitHub Check: publish_install (windows-latest, 22.x)
- GitHub Check: publish_install (windows-latest, 24.x)
- GitHub Check: publish_install (ubuntu-latest, 24.x)
- GitHub Check: publish_install (windows-latest, 20.x)
- GitHub Check: publish_install (macos-latest, 22.x)
- GitHub Check: publish_install (ubuntu-latest, 22.x)
- GitHub Check: publish_install (ubuntu-latest, 20.x)
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (4)
packages/dashboard/src/lib/framework/extension-api/types/login.ts (4)
10-10
: Version bump acknowledged – looks consistentThe
@since
tag has been updated to3.4.0
. No issues detected.
27-27
: Version bump acknowledged – looks consistentDocumentation correctly reflects
3.4.0
.
44-44
: Version bump acknowledged – looks consistentChange is purely doc-comment; implementation remains untouched.
61-61
: Version bump acknowledged – looks consistentNo further action required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some things to add. Also make sure to add @since 3.4.0
to all interfaces & types if they don't have it already
packages/dashboard/src/lib/framework/extension-api/types/detail-forms.ts
Outdated
Show resolved
Hide resolved
packages/dashboard/src/lib/framework/extension-api/types/form-components.ts
Outdated
Show resolved
Hide resolved
packages/dashboard/src/lib/framework/extension-api/types/navigation.ts
Outdated
Show resolved
Hide resolved
packages/dashboard/src/lib/framework/extension-api/types/navigation.ts
Outdated
Show resolved
Hide resolved
|
Description
This PR updates the jsDocs in exported interfaces of dashboard
📌 Always:
👍 Most of the time:
Summary by CodeRabbit