feat(core): Throw error on taxSummary if surcharges relation is not loaded #3569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DeltaSAMP is attempting to deploy a commit to the Vendure Team on Vercel. A member of the Team first needs to authorize it. |
|
michaelbromley
approved these changes
Jun 2, 2025
068176c
into
vendure-ecommerce:minor
22 of 23 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes Issue #3423 by throwing an error if the
surchargesrelation is not loaded when trying to access the ordertaxSummaryBreaking changes
no
Screenshots
You can add screenshots here if applicable.
Checklist
📌 Always:
👍 Most of the time: