Update to Swift 3 #60
Conversation
soffes
commented
Sep 20, 2016
|
@soffes looks like you need to remove the |
| // There isn't a mutable NSHTTPURLResponse, so we have to make our own. | ||
| class URLHTTPResponse: NSHTTPURLResponse { | ||
| // There isn't a mutable HTTPURLResponse, so we have to make our own. | ||
| class HTTPURLResponse: Foundation.HTTPURLResponse { |
There was a problem hiding this comment.
If this code is not brought in via a pod (directly added to a project) which flavor of HTTPURLResponse will be used throughout the code base, Foundation or this? I would argue that this class should be prefixed.
There was a problem hiding this comment.
You can directly reference via the module, that is, either DVR.HTTPURLResponse or Foundation.HTTPURLResponse.
I think having it that way is most explicit and readable.
|
I fixed the upload tests in https://github.com/soffes/DVR/pull/1. |
|
@soffes @n8armstrong Any ETA on when this'll be ready for production? |
|
@soffes @hyperspacemark @florin-pop @n8armstrong how do y'all feel about getting this PR up to date and merged into master? I feel like people have been using the |
|
Would love to have this merged! |