Ensure Validation Rule order is deterministic #383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f98809e to
88e89b4
Compare
Signed-off-by: Steve Coffman <steve@khanacademy.org>
88e89b4 to
db264eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #379 and #380 and #381
Recently, there was the beginning of an effort by @tomoikey to discourage the use of global variables in gqlparser.
Those changes, per my comment here, we have inadvertently made the order in which validation rules are applied non-deterministic.
This can cause problems in downstream projects in their continuous integration tests, as they might not get perfectly identical results due to ordering differences. This PR attempts to make the ordering of validation rules deterministic.
Note: I do NOT think this is now the best order of validation rule precedence, NOR do I think the original order was that either. They were and still are sorted arbitrarily only to have a deterministic precedence.
Also, if you were to add custom rule(s) using BOTH the deprecated and non-deprecated methods, and then to compare the validation order precedence, they would not be perfectly identical, because this is not expected to be of any consequence.
Signed-off-by: Steve Coffman steve@khanacademy.org