fix: ErrorPosf() handle nil Position input #376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rob Myers <1243316+robmyersrobmyers@users.noreply.github.com>
|
Oh, thanks! That's great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open Policy Agent prunes Position information from its AST tree prior to calling validator.ValidateSchemaDocument(), which causes a runtime error and panic when a bad schema is encountered because
ErrorPosf()does not check for nil input.This PR adds a test case and returns some default values if a
nilpos is passed toErrorPosf().The default values I've chosen may not be the best as some people do not expect row/column information to be negative. See #254, for example. I'm not tied to these values - I just don't want a crash in this case.
I didn't see any related documentation that needed an update handling this case.
I have:
go test ./...to ensure no other tests fail as a result of this changeThis resolves #375