@grivera64 I think the changes here are the same as the ones in #65 but implemented differently?

@grivera64 I think the changes here are the same as the ones in #65 but implemented differently?

@gaby Ah yes, it looks like they did a more convenient check. Instead of checking each file's declared types, that PR checks all declared types directly outside of the for loop. I think it may be cleaner to do that instead.

I believe that #65 does not include any tests though. I've added some here which should be compatible with both versions. Would you like me to edit this PR to include the maker.Make() changes from that PR instead of the current ones?

Or would we want to merge that other PR and merge this one with the new test case?

@grivera64 Lets update this one with the changes from #65 that way we can use your unit-tests

@grivera64 Lets update this one with the changes from #65 that way we can use your unit-tests

Sounds good! I will make a new commit moving the check outside of the for loop like in #65.

@gaby Done! I also reverted the name change from containsStructType back to validateStructType since it makes more sense to keep that name when it's done outside of the for loop.

@grivera64 Seems like #66 also had similar changes, although it was created by the same person as #65 so it's probably old code from another branch?

@grivera64 Seems like #66 also had similar changes, although it was created by the same person as #65 so it's probably old code from another branch?

It seems that PR #66 was created with the same commit history as #65 (maybe checked out a branch based on #65), but is an unrelated issue.

#66 tries to fix the situation where the output interface's package is different from the input package. In these cases, any non built-in types declared in the package should be prefixed by the appropriate package (and be imported) when generating the interface in the new package.