remove bitwarden licensed code and other apps #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this PR still needed? |
|
Well, maybe as a placeholder for discussing if we want to have a GPL only repository or not. I don't really care for this change at the moment because we have not yet figured out how we want to use this repository going forward. But yeah, now that this is merged the question would be if we want to replicate this change also to all newer branches too as this was still for edit: I've done so for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
web-vault should still be buildable without the code in bitwarden_license/ and from the other apps. this should also help running linting and others tests faster if we were to run them (though I don't think that they would all pass with our changes...)